Add SSLDelegateProtocol to StreamingSession #191
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Add
SSLDelegateProtocol
delegate toStreamingSession
Why
I've discovered that when initializing
OpenAI
class withURLSession
, it isn't utilized if the request usesStreamingSession
(which is logical). Consequently, if a client wishes to implementSSL Pinning
in their application and passes theirURLSession
with a set delegate (which implements thedidReceive challenge: URLAuthenticationChallenge
method fromURLSessionDelegate
),URLSessionDelegate
methods will be invoked only for requests that don't useStreamingSession
and the streaming mechanism.This PR introduces a mechanism that allows the user to pass their
delegate
inherited fromSSLDelegateProtocol
and manually handledidReceive challenge: URLAuthenticationChallenge
.Affected Areas
OpenAI
andStreamingSession
classes initializers