Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RFC] BREAKING CHANGES: A feature for every readout type (Closes #110) #111

Draft
wants to merge 18 commits into
base: main
Choose a base branch
from
Draft

[RFC] BREAKING CHANGES: A feature for every readout type (Closes #110) #111

wants to merge 18 commits into from

Conversation

grtcdr
Copy link
Member

@grtcdr grtcdr commented Dec 29, 2021 •
edited
Loading

This MR is a demonstration of #110

New readout types

  • GraphicalReadout
  • ProcessorReadout

Breaking Changes

  • Moved desktop_environment() from GeneralReadout to GraphicalReadout
  • Moved session() from GeneralReadout to GraphicalReadout
  • Moved window_manager() from GeneralReadout to GraphicalReadout
  • Moved terminal() from GeneralReadout to GraphicalReadout
  • Moved cpu_model_name() from GeneralReadout to ProcessorReadout
  • Moved cpu_usage() from GeneralReadout to ProcessorReadout
  • Moved cpu_physical_cores() from GeneralReadout to ProcessorReadout
  • Moved cpu_cores() from GeneralReadout to ProcessorReadout
  • Moved every enum within traits to a new enums module
  • Renamed os_name() in GeneralReadout to operating_system()

Features for every readout type

Every readout type is now hidden behind a feature if default-features = false.

@grtcdr grtcdr changed the title RFC n°1: (Closes #110) A feature for every readout type (Closes #110) Dec 29, 2021
@grtcdr grtcdr linked an issue Dec 29, 2021 that may be closed by this pull request
RFC: A feature for every readout type. #110
Open
@grtcdr grtcdr mentioned this pull request Dec 29, 2021
Open
@grtcdr grtcdr marked this pull request as draft December 29, 2021 20:56
@grtcdr grtcdr mentioned this pull request Dec 29, 2021
Open
@grtcdr grtcdr changed the title A feature for every readout type (Closes #110) BREAKING CHANGES: A feature for every readout type (Closes #110) Dec 29, 2021
@grtcdr grtcdr changed the title BREAKING CHANGES: A feature for every readout type (Closes #110) [RFC] BREAKING CHANGES: A feature for every readout type (Closes #110) Jun 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RFC: A feature for every readout type.
1 participant
@grtcdr