Skip to content
This repository has been archived by the owner on Oct 19, 2023. It is now read-only.

Explicitly export types from file.ts #298

Closed
wants to merge 1 commit into from
Closed

Conversation

hmps
Copy link

@hmps hmps commented Feb 12, 2021

Why

We're using node-hubspot as a part of a NextJS with Typescript. NextJS enforces use of isolatedModules with TS. And the TS compiler threw this error when we tried to build after adding hubspot:

../../node_modules/hubspot/lib/typescript/file.ts:77:29 - error TS1205: Re-exporting a type when the '--isolatedModules' flag is provided requires using 'export type'.

77 export { File, HubspotFile, HubspotImage }                               ~~~~~~~~~~~~

This change addresses the need by:

Adding type to the export statement in file.ts

Contributing guidelines

  • Run npm run build

Thank you for the work you're doing on this package! 🙏

@hmps
Copy link
Author

hmps commented Feb 13, 2021

Closing this since #293 is already addressing this issue 🤦

@hmps hmps closed this Feb 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant