Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create contributing.md file #33

Conversation

AnujSaha0111
Copy link
Contributor

Created CONTRIBUTING.md with following structure:

  1. Setting up the project: Instructions on forking the repository, cloning, and creating a new branch.
  2. Code of Conduct: Reference to a code of conduct for maintaining a respectful community.
  3. Issues: Guidelines for reporting bugs and requesting features.
  4. Pull Requests: Instructions on how to submit a pull request, including guidelines for descriptions and linking issues.
  5. Commit Messages: Standards for writing clear commit messages.
  6. Coding Guidelines: Information about the tech stack and coding style to follow.
  7. Development Workflow: Steps for running the development environment, testing, and building the project.
  8. License: Information regarding the project's license.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @AnujSaha0111 ,

Thanks for opening this PR! We appreciate your contribution and will review it as soon as we can. We’ll get back to you with any feedback or updates shortly.

Cheers🥂,

Copy link
Owner

@MadhavKrishanGoswami MadhavKrishanGoswami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @AnujSaha0111, Thank you for the effort! The style of the file looks good, but I noticed a couple of things:

  1. We don't use Python in our project.
  2. The tech stack mentioned is incorrect.

Could you please check the README.md file to confirm our correct tech stack and workflow? Once updated, everything else seems great!

Thanks again for your contribution!

Cheers🥂

@AnujSaha0111
Copy link
Contributor Author

Made changes, please review it

Copy link
Owner

@MadhavKrishanGoswami MadhavKrishanGoswami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good! However, could you please remove the Coding Guidelines section and Explanation ? Once that's done, we can go ahead with this.

Thanks!

@AnujSaha0111
Copy link
Contributor Author

AnujSaha0111 commented Oct 10, 2024

removing coding guideline section will also remove tech stack section which is subsection of coding guidelines
will I remove it?

@MadhavKrishanGoswami
Copy link
Owner

Oh, I’m sorry! Just the explanation part needs to be removed. Once that’s done, we can go ahead with this!

Thanks!

@AnujSaha0111
Copy link
Contributor Author

Done with it.

Copy link
Owner

@MadhavKrishanGoswami MadhavKrishanGoswami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution @AnujSaha0111 !
cheers 🥂

@AnujSaha0111
Copy link
Contributor Author

but, it is unmerged
Please add gssoc-ext label

@MadhavKrishanGoswami MadhavKrishanGoswami self-assigned this Oct 10, 2024
@MadhavKrishanGoswami MadhavKrishanGoswami merged commit 22c1ec3 into MadhavKrishanGoswami:main Oct 10, 2024
2 checks passed
@MadhavKrishanGoswami
Copy link
Owner

Really sorry for the confusion, and thank you for your contribution, @AnujSaha0111! 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants