-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create contributing.md file #33
Create contributing.md file #33
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @AnujSaha0111 ,
Thanks for opening this PR! We appreciate your contribution and will review it as soon as we can. We’ll get back to you with any feedback or updates shortly.
Cheers🥂,
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @AnujSaha0111, Thank you for the effort! The style of the file looks good, but I noticed a couple of things:
- We don't use Python in our project.
- The tech stack mentioned is incorrect.
Could you please check the README.md file to confirm our correct tech stack and workflow? Once updated, everything else seems great!
Thanks again for your contribution!
Cheers🥂
Made changes, please review it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks good! However, could you please remove the Coding Guidelines section and Explanation ? Once that's done, we can go ahead with this.
Thanks!
removing coding guideline section will also remove tech stack section which is subsection of coding guidelines |
Oh, I’m sorry! Just the explanation part needs to be removed. Once that’s done, we can go ahead with this! Thanks! |
Done with it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution @AnujSaha0111 !
cheers 🥂
but, it is unmerged |
22c1ec3
into
MadhavKrishanGoswami:main
Really sorry for the confusion, and thank you for your contribution, @AnujSaha0111! 🙌 |
Created CONTRIBUTING.md with following structure: