Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set name and path in module init #3710

Closed
wants to merge 1 commit into from

Conversation

khassel
Copy link
Collaborator

@khassel khassel commented Jan 31, 2025

This is a solution for #3708

I set it to draft because I'm not sure if it should be merged.

With this change the this.name will now work in the init function but for get this working in a module you have to copy the content of the node_helper init into your module. This is nothing new, you have to do the same for e.g. start.

AFAIS the used construction in js/class.js misses inheritence for this.

@khassel
Copy link
Collaborator Author

khassel commented Jan 31, 2025

test fails will be fixed with #3709

@sdetweil
Copy link
Collaborator

yeh, I dont think we should go that way

@khassel
Copy link
Collaborator Author

khassel commented Feb 1, 2025

o.k.

@khassel khassel closed this Feb 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants