Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove invalid first_line_match key #119

Closed
wants to merge 1 commit into from

Conversation

pchaigno
Copy link
Contributor

This pull request removes the invalid first_line_match key from grammar files. I'm not sure if this is the old version of firstLineMatch or an error, but it's raising errors on GitHub.com (see github-linguist/linguist#3924 for further details).

@pchaigno
Copy link
Contributor Author

pchaigno commented Jan 6, 2018

@1st1 Did you get a chance to look into this?

@pchaigno
Copy link
Contributor Author

pchaigno commented Feb 10, 2018

@vpetrovykh @1st1 Did one of you find time to look into this? 😃

@vpetrovykh
Copy link
Member

I have manually rebased and merged this as b2b4f4a

Sorry for the long delay.

@vpetrovykh vpetrovykh closed this Jul 31, 2020
@pchaigno
Copy link
Contributor Author

Thanks!

@pchaigno pchaigno deleted the remove-invalid-key branch July 31, 2020 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants