Merge pull request #15 from bmeijwaard/cards.variations_exception

Cards.variations exception
MagicTheGathering · Mar 29, 2019 · 64cf70e · 64cf70e
2 parents 2c98bd1 + d67e5d4
commit 64cf70e
Show file tree

Hide file tree

Showing 5 changed files with 13 additions and 13 deletions.
diff --git a/MtgApiManager.Lib.Test/Model/CardTest.cs b/MtgApiManager.Lib.Test/Model/CardTest.cs
@@ -78,7 +78,7 @@ public void MapCardTest()
                 Toughness = "tough",
                 Type = "type2",
                 Types = new string[] { "type1", "type2" },
-                Variations = new int[] { 1, 2, 3 },
+                Variations = new string[] { Guid.Empty.ToString() },
                 Watermark = "watermark"
             };
 

diff --git a/MtgApiManager.Lib.Test/Service/CardServiceTest.cs b/MtgApiManager.Lib.Test/Service/CardServiceTest.cs
@@ -71,7 +71,7 @@ public async Task AllAsyncTest()
                     Toughness = "tough",
                     Type = "type2",
                     Types = new string[] { "type1", "type2" },
-                    Variations = new int[] { 1, 2, 3 },
+                    Variations = new string[] { Guid.Empty.ToString() },
                     Watermark = "watermark"
                 },
                 new CardDto()
@@ -113,7 +113,7 @@ public async Task AllAsyncTest()
                     Toughness = "tough",
                     Type = "type2",
                     Types = new string[] { "type1", "type2" },
-                    Variations = new int[] { 1, 2, 3 },
+                    Variations = new string[] { Guid.Empty.ToString() },
                     Watermark = "watermark"
                 }
             };
@@ -215,7 +215,7 @@ public void AllTest()
                     Toughness = "tough",
                     Type = "type2",
                     Types = new string[] { "type1", "type2" },
-                    Variations = new int[] { 1, 2, 3 },
+                    Variations = new string[] { Guid.Empty.ToString() },
                     Watermark = "watermark"
                 },
                 new CardDto()
@@ -257,7 +257,7 @@ public void AllTest()
                     Toughness = "tough",
                     Type = "type2",
                     Types = new string[] { "type1", "type2" },
-                    Variations = new int[] { 1, 2, 3 },
+                    Variations = new string[] { Guid.Empty.ToString() },
                     Watermark = "watermark"
                 }
             };
@@ -358,7 +358,7 @@ public async Task FindAsyncTest()
                 Toughness = "tough",
                 Type = "type2",
                 Types = new string[] { "type1", "type2" },
-                Variations = new int[] { 1, 2, 3 },
+                Variations = new string[] { Guid.Empty.ToString() },
                 Watermark = "watermark"
             };
 
@@ -501,7 +501,7 @@ public void FindTest()
                 Toughness = "tough",
                 Type = "type2",
                 Types = new string[] { "type1", "type2" },
-                Variations = new int[] { 1, 2, 3 },
+                Variations = new string[] { Guid.Empty.ToString() },
                 Watermark = "watermark"
             };
 

diff --git a/MtgApiManager.Lib.Test/Service/SetServiceTest.cs b/MtgApiManager.Lib.Test/Service/SetServiceTest.cs
@@ -463,7 +463,7 @@ public async Task GenerateBoosterAsyncTest()
                     Toughness = "tough",
                     Type = "type2",
                     Types = new string[] { "type1", "type2" },
-                    Variations = new int[] { 1, 2, 3 },
+                    Variations = new string[] { Guid.Empty.ToString() },
                     Watermark = "watermark"
                 },
                 new CardDto()
@@ -505,7 +505,7 @@ public async Task GenerateBoosterAsyncTest()
                     Toughness = "tough",
                     Type = "type2",
                     Types = new string[] { "type1", "type2" },
-                    Variations = new int[] { 1, 2, 3 },
+                    Variations = new string[] { Guid.Empty.ToString() },
                     Watermark = "watermark"
                 }
             };
@@ -606,7 +606,7 @@ public void GenerateBoosterTest()
                     Toughness = "tough",
                     Type = "type2",
                     Types = new string[] { "type1", "type2" },
-                    Variations = new int[] { 1, 2, 3 },
+                    Variations = new string[] { Guid.Empty.ToString() },
                     Watermark = "watermark"
                 },
                 new CardDto()
@@ -648,7 +648,7 @@ public void GenerateBoosterTest()
                     Toughness = "tough",
                     Type = "type2",
                     Types = new string[] { "type1", "type2" },
-                    Variations = new int[] { 1, 2, 3 },
+                    Variations = new string[] { Guid.Empty.ToString() },
                     Watermark = "watermark"
                 }
             };

diff --git a/MtgApiManager.Lib/Dto/Cards/CardDto.cs b/MtgApiManager.Lib/Dto/Cards/CardDto.cs
@@ -276,7 +276,7 @@ public string[] Types
         }
 
         [JsonProperty(PropertyName = "variations")]
-        public int[] Variations
+        public string[] Variations
         {
             get;
             set;

diff --git a/MtgApiManager.Lib/Model/Card/Card.cs b/MtgApiManager.Lib/Model/Card/Card.cs
@@ -368,7 +368,7 @@ public string[] Types
         /// <summary>
         /// Gets if a card has alternate art (for example, 4 different Forests, or the 2 Brothers Yamazaki) then each other variation’s multiverseid will be listed here, NOT including the current card’s multiverseid.
         /// </summary>
-        public int[] Variations
+        public string[] Variations
         {
             get;
             private set;
-Original file line number
+Diff line change
@@ Expand Up / @@ -276,7 +276,7 @@ public string[] Types @@
             }
             [JsonProperty(PropertyName = "variations")]
-            public int[] Variations
+            public string[] Variations
             {
                 get;
                 set;
@@ Expand Down @@