add prd of WallectConnect general component #330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Danie0918
reviewed
May 30, 2023
There was a problem hiding this comment.
While connecting, connecting by Walletconnec code should be disabled.
There was a problem hiding this comment.
Yes, and the WalletConnect code way should also be removed from the formal demo.
cc @Kirl70
Keith-CY
reviewed
May 30, 2023
Comment on lines
15
to
25
| #### Status1: Unconnected | ||
|
|
||
| While the dapp is unconnected with the wallet, users can click on the button below to scan QR code on the dapp side in order to connect the dapp. | ||
|
|
||
|  | ||
|
|
||
| #### Status2: Connecting | ||
|
|
||
| After clicking the scan button, and if the QR code is correct then the dapp and wallet are trying to communicate following the protocol. If the QR code is not in correct format, corresponding messages will be popped up. | ||
|
|
||
|  |
There was a problem hiding this comment.
IMO, the status of disconnection and connecting is quite similar to account model of Ethereum because the interaction is the same:
1. connect wallet
2. waiting
3. show wallet/show error message
So the current UX of wallet connect can be used
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add PRD of WallectConnect general component. Pls check ~ @Keith-CY @Danie0918