Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

setMask on NavDataManager is not called correctly from adding/removing listeners #23

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

setMask on NavDataManager is not called correctly from adding/removing listeners #23

wants to merge 2 commits into from

Conversation

jfbenckhuijsen
Copy link

No description provided.

ronsmits and others added 2 commits July 5, 2014 21:21
@ronsmits
mavenized
e04059f
@jfbenckhuijsen
Fixed setting state on adding or removing listeners. In the old setup,
90a9536 
the mask was only set in case *listeners.size() > 2. Otherwise, the mask
was always reset. Now, the reset is only performed if the number of
listeners drops to 0, and set if there is one listener present (assuming
it's the first).
@jfbenckhuijsen jfbenckhuijsen mentioned this pull request Jul 16, 2014
Closed
@jfbenckhuijsen jfbenckhuijsen changed the title Fix nav listener setMask on NavDataManager is not called correctly from adding/removing listeners Jul 16, 2014
@jfbenckhuijsen
Copy link
Author

Branched from our maveninzed branch. The fix is in the single commit in this branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jfbenckhuijsen @ronsmits