Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix retrieving of software version and store last speed indication #61

Merged
merged 7 commits into from
Nov 15, 2020
Merged

Fix retrieving of software version and store last speed indication #61

merged 7 commits into from
Nov 15, 2020

Conversation

thegreatdane6
Copy link
Contributor

@thegreatdane6 thegreatdane6 commented Nov 13, 2020 •
edited
Loading

closes #60
closes #37
closes #35

@thegreatdane6 thegreatdane6 changed the title Fix/60 Fix retrieving of software version and store last speed indication Nov 13, 2020
@thegreatdane6 thegreatdane6 marked this pull request as ready for review November 13, 2020 18:27
@angrox angrox added the firmware Affects the development of the firmware label Nov 14, 2020
angrox
angrox approved these changes Nov 15, 2020
View reviewed changes
Copy link
Collaborator

@angrox angrox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally with esp32 + rotary.

@thegreatdane6 thegreatdane6 merged commit f19833e into main Nov 15, 2020
@thegreatdane6 thegreatdane6 deleted the fix/60 branch November 15, 2020 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@angrox angrox angrox approved these changes

@mlkiefer mlkiefer Awaiting requested review from mlkiefer

Assignees
No one assigned
Labels
firmware Affects the development of the firmware
Projects
None yet
Milestone
No milestone
3 participants
@thegreatdane6 @angrox @dane-marvin-dahlem-mw