Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug/3979/web demo version #3982

Merged
merged 5 commits into from
Feb 28, 2025
Merged

Bug/3979/web demo version #3982

merged 5 commits into from
Feb 28, 2025

Conversation

BenediktMehl
Copy link
Collaborator

Web demo gets reset to Version 1.132.1

Closes: #3979

Description

Every time the "Deploy to GitHub Pages" workflow got triggered the web demo was reset, because the deployment uses the gh-folder as source. The web demo build in that folder is never updated, because the release-visualization.yml directly deploys the release artifacts to the gh-pages branch.

Solution is just deleting the visualization folder inside the gh-pages folder on main, so the visualization folder on the gh-pages branch is no touched by the deploy-github-pages workfow.

Also I changed that all the time a clean deployment is dont because else there are very old and unused files on the gh-pages branch.

Definition of Done

A PR is only ready for merge once all the following acceptance criteria are fulfilled:

  • Changes have been manually tested
  • All TODOs related to this PR have been closed
  • There are automated tests for newly written code and bug fixes
  • All bugs discovered while working on this PR have been submitted as issues (if not already an open issue)
  • Documentation (GH-pages, analysis/visualization READMEs, parser READMEs, --help, etc.) has been updated (almost always necessary except for bug fixes)
  • CHANGELOG.md has been updated

Screenshots or gifs

This needs to be done because else deployments to github pages always reset the state of the web demo to the state in that folder, which is never updated.
Copy link

Copy link

@BenediktMehl BenediktMehl merged commit 64f52ae into main Feb 28, 2025
2 checks passed
@BenediktMehl BenediktMehl deleted the bug/3979/web-demo-version branch February 28, 2025 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Web Demo not updated
2 participants