translate tiles by -10 in z in default plot config #126
Conversation
| # note that all translation / scaling is done by the arguments | ||
| # not by modifying the plot's transformation as was done in previous Tyler v0.1.5 and below | ||
| # so this should hold indefinitely | ||
| translate!(p, 0, 0, -10) |
There was a problem hiding this comment.
This seems to be in the ElevationData dispatch ...
There was a problem hiding this comment.
doh, yeah that should be in the imagedata dispatch
There was a problem hiding this comment.
Even in the right spot this approach doesnt seem to work, during zoom tiles cover e.g. a scatter plot anyway. But at least the scatter does come back after zooming
There was a problem hiding this comment.
And seems sometimes they dont come back after zooming either
There was a problem hiding this comment.
We need to turn down the depth_shift to something like ´n / 100000f0´ and then it works on my branch. so some progress!
There was a problem hiding this comment.
ah, that's because the depth shift is a multiplier then. Makes sense.
How about n * 10*eps(1f0) instead? It's probably more obvious what we're trying to do and the values are similarly inconsequential.
There was a problem hiding this comment.
Eps is for values at zero. It's obvious what you're doing but the scale will need to be much larger
There was a problem hiding this comment.
The range is always (-1, 1) though, and eps with a number is actually the correct nextfloat epsilon:
julia> eps(1f0)
1.1920929f-7
julia> eps(10000f0)
0.0009765625f0But either way works
There was a problem hiding this comment.
The numbers are between 0 and 100 before scaling, or like 0 and 25 or whatever
There was a problem hiding this comment.
You can review the PR ad edit the code inline if you really want to change it ;)
To ensure that plots will always remain above the map