Add noopener noreferrer to blank targets #1883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoids tabnapping exploits. See [CWE-1022](https://cwe.mitre.org/data/definitions/1022.html)
|
Checked commit Fryguy@1dadcc2 with ruby 2.7.8, rubocop 1.56.3, haml-lint 0.51.0, and yamllint |
DavidResende0
approved these changes
Feb 6, 2024
There was a problem hiding this comment.
LGTM, only thing I noticed was that the documentation button redirects you to here:
While in the admin ui it takes you straight to the documentation (i.e. https://www.manageiq.org/docs/)
|
@DavidResende0 Let me double check that, but I think that's intentional as it allows for overriding the link in productized versions. |
|
Backported to |
Fryguy
pushed a commit
that referenced
this pull request
Feb 7, 2024
Add noopener noreferrer to blank targets (cherry picked from commit 89aa04e)
|
Backported to |
Fryguy
pushed a commit
that referenced
this pull request
Feb 8, 2024
Add noopener noreferrer to blank targets (cherry picked from commit 89aa04e)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids tabnapping exploits.
See CWE-1022
@DavidResende0 Please review.