Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecate attribute no longer uses virtual attribute #23321

Merged
merged 1 commit into from
Feb 11, 2025

Conversation

kbrock
Copy link
Member

@kbrock kbrock commented Feb 3, 2025

virtual_attribute marked the attribute for discovery we have modified discovery to include aliases so it is no longer necessary

Depends upon:

Can be merged without those, but need them to ensure the attributes are still exposed in automate and the api

virtual_attribute marked the attribute for discovery
we have modified discovery to include aliases so it is no longer necessary
@kbrock kbrock force-pushed the deprecation_aliases branch from b3a41bd to 4b05909 Compare February 10, 2025 17:19
@jrafanie
Copy link
Member

Kicking now that the other PRs were merged

@jrafanie jrafanie closed this Feb 11, 2025
@jrafanie jrafanie reopened this Feb 11, 2025
@jrafanie
Copy link
Member

@miq-bot cross-repo-tests /all

miq-bot pushed a commit to ManageIQ/manageiq-cross_repo-tests that referenced this pull request Feb 11, 2025
Copy link
Member

@jrafanie jrafanie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merging, cross repo is 💚

@jrafanie jrafanie merged commit 290f142 into ManageIQ:master Feb 11, 2025
14 checks passed
@kbrock kbrock deleted the deprecation_aliases branch February 11, 2025 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants