chore: use logger context #657
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mRoca
force-pushed
the
chore/refacto-logs
branch
from
c598bef
to
550c3e8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces all
$this->logger->debug('Response JSON : ' . print_r($responseResult->Body, true));by 2 logs (request and response) with a static message and all variable data passed in the context.This refacto allows using a custom Logger and getting variable data without parsing actual log messages in order to transform
print_rstrings back into php or json array.Debugcalls have been refactored in order to avoid duplication ofif ($this->_root->Config->DebugMode) {