Implement inserting items into FrozenMap with a callback function.
#49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Manishearth
reviewed
Jul 25, 2023
| // these should never return &K or &V | ||
| // these should never delete any entries | ||
| pub fn insert(&self, k: K, v: V) -> &V::Target { | ||
| pub fn insert_with(&self, k: K, v: impl FnOnce() -> V) -> &V::Target { |
There was a problem hiding this comment.
please update the safety comment on in_use to mention the insert_with callback in addition to eq etc
|
Actually, I'm not going to merge this for now: To fix #48 I may end up encapsulating the map differently; and a very nice property that comes out of that is that I may no longer need a reentrancy guard. But that makes this function illegal. So I'm going to hold off on merging this. |
|
Ok, thanks for your response |
|
May reopen based on how we resolve #48 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature supports the use case where creating the item is expensive and can be omitted in case it's not in the map yet.