-
-
Notifications
You must be signed in to change notification settings - Fork 375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Windows MapScript for Conda build #7105
Conversation
Thanks @hobu ! Note to self: shell-paths for converting slashes in paths dependent on OS. |
@@ -1,5 +1,14 @@ | |||
#!/bin/sh | |||
|
|||
if [ "$RUNNER_OS" == "Windows" ]; then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is weird that we have to explicitly specify SWIG_EXECUTABLE. We don't need to do that for GDAL builds
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This could probably be removed. It was in the mapserver feedstock and I carried it along from there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This could probably be removed
indeed: #7109
IMO the Python MapScript install stuff should be refactored to use "modern" Python packaging installation stuff instead of hand copying files around to paths. Some of the items that would entail include:
|
@hobu - there are definitely some improvements that can be made such as a move to a .toml file, but I'm not sure if there is a "clean" way when building with a combination of SWIG, CMake, and Python packaging. Setting GDAL also relies on several path manipulations in https://github.com/rouault/gdal/blob/master/swig/python/osgeo/__init__.py Copying files with CMake is required to gather the files from the source repository such as tests so they can be alongside the SWIG generated .py file and a .pyd file and added to the wheel. |
Follow up to #7102 to add MapScript builds as well on all three platforms