Make map-properties popup size dynamic #1017
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prushforth
reviewed
Dec 6, 2024
| const map = layer._map; | ||
| const popupOptions = { | ||
| autoClose: false, | ||
| autoPan: true, |
There was a problem hiding this comment.
I believe the autoPan value was the default false and that was intentional so that the map wouldn't keep panning and pulling in new features, which might be a problem for a screenreader user (?). That was my theory anyhow. I guess we can keep this value and see if it engenders any comment from anyone else though.
prushforth
reviewed
Dec 6, 2024
| @@ -70,11 +70,18 @@ export var TemplatedFeaturesLayer = Layer.extend({ | |||
| projection: map.options.projection, | |||
| mapEl: this._linkEl.getMapEl(), | |||
| onEachFeature: function (properties, geometry) { | |||
| const popupOptions = { | |||
There was a problem hiding this comment.
I believe the autoPan value was the default false and that was intentional so that the map wouldn't keep panning and pulling in new features, which might be a problem for a screenreader user (?). That was my theory anyhow. I guess we can keep this value and see if it engenders any comment from anyone else though.
prushforth
approved these changes
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #893