Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Issue #456 #707 #723 - Ignore() processing improvements #763

Draft
wants to merge 6 commits into
base: development
Choose a base branch
from

Conversation

DocSvartz
Copy link

@DocSvartz DocSvartz commented Jan 21, 2025

#456 When explicitly set to ignore():

  1. Instance of a class can be created with default values ​​for parameters.
  2. Explicitly set to ignore() not mark param as not matched when config RequireDestinationMemberSource = true,

#707 #723 RecordTypes and Generated Type to Interface received support Ignore() from Ctor parameters

@DocSvartz
Copy link
Author

@andrerav @lofcz This will also resolve issue #723.
By calling the constructor with a default parameter.
Instead of creating a constructor without this parameter. As in the previous solution #761.

Which of the two solutions presented is better?

I think seems this solution is better. Especially if these created classes are used in other mappings. 🤔

@andrerav
Copy link
Contributor

Great @DocSvartz. Whenever you have PR's that you think is ready to be merged, could you please assign me as reviewer and I will review as soon as I can?

@DocSvartz
Copy link
Author

DocSvartz commented Jan 22, 2025

@andrerav Ok

@DocSvartz DocSvartz changed the title Fix Issue #456 #707 - Ignored() processing improvements Fix Issue #456 #707 # 723 - Ignored() processing improvements Jan 22, 2025
@DocSvartz DocSvartz changed the title Fix Issue #456 #707 # 723 - Ignored() processing improvements Fix Issue #456 #707 #723 - Ignored() processing improvements Jan 22, 2025
@DocSvartz DocSvartz requested a review from andrerav January 22, 2025 14:34
@DocSvartz DocSvartz changed the title Fix Issue #456 #707 #723 - Ignored() processing improvements Fix Issue #456 #707 #723 - Ignore() processing improvements Jan 23, 2025
@DocSvartz
Copy link
Author

DocSvartz commented Jan 23, 2025

linked #458 mapping to ctor with ignore (other problems there are related to record detection in 7.4.0 #537)

@DocSvartz DocSvartz removed the request for review from andrerav January 25, 2025 05:38
@DocSvartz
Copy link
Author

@andrerav This not ready for RecordType (
In terms of the fixes. It's more convenient for me to add them as one PR.
But then it will be more difficult to review.

Or I can enable it only for Classes.
And for records this will already be included as part of the fix MapTotarget behavior for RecordType (new PR)?

@DocSvartz DocSvartz requested review from andrerav and removed request for andrerav January 25, 2025 06:12
@DocSvartz DocSvartz marked this pull request as draft January 25, 2025 11:29
@DocSvartz
Copy link
Author

I think this can be closed. I improved it and added to PR #769.
In which I hope I finally managed to fix MapToTarget for RecordType ))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants