You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Old style: max wave amplitude is maxHeight, and 'z_scale' is determined by average color of a rect area that's directly relative to maxHeight:
New style: max wave amplitude is waveIntensity, and 'z_scale' is determined by average color of a line of pixels:
Although it's a mere artistic choice, I prefer my style since it can capture details better(notice in the second-second image how you can still see the face even with high "Wave Spacing" value).
Edited 'Converter_IntensityToHeight.java'
Better Converter_IntensityToHeight implementation at capturing image details with less space calculations.
previous version determines 'z_scale' based on the average color of a rect, my method determines it based on a horizontal line average color;
Thus, I got rid of 'maxHeight' and added 'waveIntensity'
so you changed the name of maxHeight to waveIntensity? I'm still confused what this does. I don't seem to be able to get this branch to test what you've done. I'm doing something wrong and I feel a little dumb...
so you changed the name of maxHeight to waveIntensity? I'm still confused what this does. I don't seem to be able to get this branch to test what you've done. I'm doing something wrong and I feel a little dumb...
No; waveIntensity is much different than maxHeight although they're meant to partially represent a similar concept which is the maximum amplitude of a wave.
Got rid of maxHeight and all its relatives(such as its slider and getters\setters, translator reference..etc).
Explaining the artistic difference would be much easier in a call so let me know when you're up for a discord call.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
waveIntensitymaximum amplitude for a wave.maxHeightOld style: max wave amplitude is
maxHeight, and 'z_scale' is determined by average color of a rect area that's directly relative tomaxHeight:New style: max wave amplitude is
waveIntensity, and 'z_scale' is determined by average color of a line of pixels:Although it's a mere artistic choice, I prefer my style since it can capture details better(notice in the second-second image how you can still see the face even with high "Wave Spacing" value).