-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable Interprocedural Optimization #3585
Draft
grooverdan
wants to merge
10
commits into
MariaDB:10.6
Choose a base branch
from
grooverdan:10.6-testinterprocedural-optimization
base: 10.6
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Enable Interprocedural Optimization #3585
grooverdan
wants to merge
10
commits into
MariaDB:10.6
from
grooverdan:10.6-testinterprocedural-optimization
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Interprocedural Optimization (LTO) provides generally good benefits for performance. Lets enable this where supported. To achieve this gain we need to be strict and accurate with function prototypes and casting and not rely on undefined behaviour.
…sentation_for_bit
Does not make sense to enable it on Debug builds, and even on Release builds, it should be optional, as it (usually) takes longer time. It makes sense to enable it on release builds on CI, maybe, after we measure some positive effect of it. |
This was largely a test of what fails and where. Thinking maybe a full test CI. I'm trying keep "options" to a managed set we can actually test. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Interprocedural Optimization (LTO) provides generally good benefits for performance. Lets enable this where supported.
To achieve this gain we need to be strict and accurate with function prototypes and casting and not rely on undefined behaviour.
Release Notes
Enable Interprocedural Optimization (LTO) for most of the codebase.
How can this PR be tested?
Though all the test in CI.
Basing the PR against the correct MariaDB version
main
branch.PR quality check