Preserve JS Object types in state persistance #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IndexedDB uses the structured clone algorithm[1] which understands JS object types like `Date` or `Set` that is lost casting the state back and forth to JSON strings. Reactivity is removed from the object being stored which is why cloneDeep is included as indexedDB requires plain objects. Removing the Proxy[2] on this.state with lodash cloneDeep. 1: https://developer.mozilla.org/en-US/docs/Web/API/Web_Workers_API/Structured_clone_algorithm 2: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Proxy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fantastic example repo and thanks for the write up, Instead of fighting json when hydrating the state form the store with JS types, I found since this example sticks to indexedDB that supports JS object directly, you only need to tangle with JSON if you want to use another store for compatibility like webSQL or localstorage.
It would be nice to not pull in lodash but that's a better solution that anything I tried.
1: indexedDB structured clone algorithm
2: Proxy