Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Typescript Type Errors #2616

Closed
wants to merge 0 commits into from
Closed

Conversation

gerteck
Copy link
Contributor

@gerteck gerteck commented Feb 27, 2025

What is the purpose of this pull request?

  • Documentation update
  • Bug fix
  • Feature addition or enhancement
  • Code maintenance
  • DevOps
  • Improve developer experience
  • Others, please explain:

Overview of changes:

Resolves #2613

TSC Errors Fixed:
ts2694, ts2790, ts4023

Fixed ts2694. This was fixed in respective dependency @types/[email protected], so bumped version to 14.1.2. Hence, also bumped markdown-it version.

See relevant issues:

  • github.com/DefinitelyTyped/DefinitelyTyped/issues/69526
  • github.com/DefinitelyTyped/DefinitelyTyped/pull/69492

Fixed ts2790 to make operand of 'delete' optional. Not sure why this was not flagged out earlier by typescript, since it was added in [email protected] and the depedency for typescript in package.json is ^4.6.2. Could be due to some other type packages.

Fixed ts4023 by explicitly declaring types for each member of the exported _ object to avoid type conflicts with uniqueSymbol in Lodash's type definitions.

src/Site/constants.ts(18,14): error TS4023: Exported variable '_' has or is using name 'uniqueSymbol' from external module "/markbind/node_modules/@types/lodash/common/object" but cannot be named.

Fixed stylelint for *.vue file:

packages/vue-components/src/SearchbarPageItem.vue
  105:21  ✖  Unexpected deprecated keyword "break-word" for property "word-break"  declaration-property-value-keyword-no-deprecated

✖ 1 problem (1 error, 0 warnings)

Anything you'd like to highlight/discuss:

Testing instructions:

Same as per #2613

  1. Delete package-lock.json and node_modules
  2. Run npm install
  3. Run npm run setup

Should have no errors.

Proposed commit message: (wrap lines at 72 characters)


Checklist: ☑️

  • Updated the documentation for feature additions and enhancements
  • Added tests for bug fixes or features
  • Linked all related issues
  • No unrelated changes

Reviewer checklist:

Indicate the SEMVER impact of the PR:

  • Major (when you make incompatible API changes)
  • Minor (when you add functionality in a backward compatible manner)
  • Patch (when you make backward compatible bug fixes)

At the end of the review, please label the PR with the appropriate label: r.Major, r.Minor, r.Patch.

Breaking change release note preparation (if applicable):

  • To be included in the release note for any feature that is made obsolete/breaking

Give a brief explanation note about:

  • what was the old feature that was made obsolete
  • any replacement feature (if any), and
  • how the author should modify his website to migrate from the old feature to the replacement feature (if possible).

@gerteck gerteck marked this pull request as draft February 27, 2025 14:26
@gerteck gerteck closed this Feb 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Package.json / Package-lock.json dependency Issue
1 participant