Fix issues with serve
and URL of live preview
#2621
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
Overview of changes:
Fixes #2617
Fixes #2620
Anything you'd like to highlight/discuss:
nil
Testing instructions:
To test fixes for #2617:
markbind serve -a ::1
.http://[::1]:8080/
, i.e. the IPv6 address is wrapped in square brackets to form a valid URL. IPv4 addresses should not be affected/adjusted.To test fixes for #2620:
Serve a MarkBind site using an unavailable address, such as:
markbind serve -a 1.1.1.1
markbind serve -a 192.168.1.0
Alternatively, send the same command with an originally available address twice, effectively making that address unavailable for the second
serve
command.The URL opened after serving the site should be the one the MarkBind site is actually hosted on, not the unavailable address provided in the command.
Proposed commit message: (wrap lines at 72 characters)
Fix issues with
serve
and URL of live previewAdd square brackets
[]
to IPv6 addresses and fixes issue regardingunavailable address and opening the wrong URL.
Checklist: ☑️
Reviewer checklist:
Indicate the SEMVER impact of the PR:
At the end of the review, please label the PR with the appropriate label:
r.Major
,r.Minor
,r.Patch
.Breaking change release note preparation (if applicable):