Vue Migration Reformatted #2622
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
compileTemplate and renderToString are now included as dependencies of the main vue package, alongside API changes to methods provided. Bundled vue js file has also been updated.
Update syntax as well as dependencies, libraries to be Vue 3 compatible
Rebuild markbind bundles as well as vue bundles Vue now needs to be externalized for both client and server
gerteck
force-pushed
the
branch-vueMigrationFormatted
branch
from
7e3f433 to
6bcf6db
Compare
Further update core-web package.
Vue needs to be externalized separately for server ('vue') and
web-client ('Vue'), or it fails for case-sensitive systems
e.g. Ubuntu. Also update index.js to use compiled render function
and use updated Vue application mounting API.
When question component not used in quiz, certain buttons are rendered on server-side but not on client. Change the visibility of these buttons to hidden, but maintain in the DOM to prevent hydration mismatch.
Vue testcases overhauled due to changes in API. Additionally, improvement can be made to vue testcases in the future as snapshots make it hard to diagnose if change is intended or unexpected bug causing side effect.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP
PR message will be updated once PR is finalized.
This PR aims to keep changes digestable through modular and understandable commits.
What is the purpose of this pull request?
Overview of changes:
Anything you'd like to highlight/discuss:
Testing instructions:
Proposed commit message: (wrap lines at 72 characters)
Vue Migration
Checklist: ☑️
Reviewer checklist:
Indicate the SEMVER impact of the PR:
At the end of the review, please label the PR with the appropriate label:
r.Major,r.Minor,r.Patch.Breaking change release note preparation (if applicable):