Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ProUI ExtUI | EXTENSIBLE_UI, fixes & cleanup #26917

Open
wants to merge 51 commits into
base: bugfix-2.1.x
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
51 commits
Select commit Hold shift + click to select a range
6e4d1fa
update encoder.cpp LED_Action
classicrocker883 Mar 28, 2024
4a8b521
marlinui_HD44780.cpp remove whitespace
classicrocker883 Mar 28, 2024
015bfcb
Merge branch 'bugfix-2.1.x' of https://github.com/MarlinFirmware/Marl…
classicrocker883 Apr 1, 2024
c273079
changes, fixes
classicrocker883 Apr 1, 2024
670a867
Merge branch 'bugfix-2.1.x' of https://github.com/MarlinFirmware/Marl…
classicrocker883 Apr 5, 2024
21d3d37
fix for ExtUI startup, various tweaks
classicrocker883 Apr 5, 2024
53b2e49
add #if for PID
classicrocker883 Apr 5, 2024
424c83d
temp.cpp isbed?
classicrocker883 Apr 5, 2024
653f338
#if for PID DGUSS
classicrocker883 Apr 5, 2024
489afcb
revert encoder struct uint
classicrocker883 Apr 5, 2024
eecc290
Merge branch 'bugfix-2.1.x' of https://github.com/MarlinFirmware/Marl…
classicrocker883 Apr 6, 2024
84b0068
space, tweak printstats
classicrocker883 Apr 6, 2024
122be88
revert encoder
classicrocker883 Apr 8, 2024
5388d95
revert these changes to another PR
classicrocker883 Apr 8, 2024
9bbba4c
revert
classicrocker883 Apr 8, 2024
1d9df23
add missing confim, fix switch warning, update popup
classicrocker883 Apr 8, 2024
441a8e8
update chamber PID, add missing
classicrocker883 Apr 9, 2024
15a81cc
Update dwin.cpp #include extui
classicrocker883 Apr 18, 2024
c480580
revert some extui, update proui popup
classicrocker883 May 11, 2024
25868fc
Merge branch 'bugfix-2.1.x' of https://github.com/MarlinFirmware/Marl…
classicrocker883 May 29, 2024
87a407b
update language msg_
classicrocker883 May 29, 2024
6dee114
revert ui_api.h
classicrocker883 May 29, 2024
94df082
Update DGUSScreenHandler.cpp
classicrocker883 May 29, 2024
6e33ae4
remove space DGUSScreenHandler.cpp
classicrocker883 May 29, 2024
62dab77
update PID tuning - revert some, update tests
classicrocker883 May 29, 2024
1d6eea6
update dwin.cpp drawMainArea() - MPC_STARTED
classicrocker883 Jun 8, 2024
813e457
update proui ExtUI onMPCTuning
classicrocker883 Jun 8, 2024
fb19dfb
Merge branch 'bugfix-2.1.x' of https://github.com/MarlinFirmware/Marl…
classicrocker883 Jun 27, 2024
5839cef
Merge branch 'bugfix-2.1.x' of https://github.com/MarlinFirmware/Marl…
classicrocker883 Aug 2, 2024
85bff40
Merge branch 'bugfix-2.1.x' of https://github.com/MarlinFirmware/Marl…
classicrocker883 Aug 10, 2024
9c5407d
revert ExtUI / EXTENSIBLE_UI
classicrocker883 Aug 11, 2024
0990cba
Merge branch 'bugfix-2.1.x' of https://github.com/MarlinFirmware/Marl…
classicrocker883 Sep 17, 2024
cd9fb39
revert some changes
classicrocker883 Oct 10, 2024
412590b
Merge branch 'bugfix-2.1.x' of https://github.com/MarlinFirmware/Marl…
classicrocker883 Oct 10, 2024
303a45b
revert more changes
classicrocker883 Oct 10, 2024
5b69d43
language_en.h
classicrocker883 Oct 11, 2024
6f521de
language_en.h
classicrocker883 Oct 11, 2024
ee0530f
Merge branch 'bugfix-2.1.x' of https://github.com/MarlinFirmware/Marl…
classicrocker883 Oct 11, 2024
b2ac2cb
fix typo #else if => #elif error
classicrocker883 Oct 12, 2024
ed2a165
include bed_mesh_t
classicrocker883 Oct 12, 2024
5eafdc1
Merge branch 'bugfix-2.1.x' of https://github.com/MarlinFirmware/Marl…
classicrocker883 Oct 21, 2024
5ced7c1
Merge branch 'bugfix-2.1.x' of https://github.com/MarlinFirmware/Marl…
classicrocker883 Oct 31, 2024
9628f37
update PID/MPC ExtUI
classicrocker883 Oct 31, 2024
30a10a7
revert some changes
classicrocker883 Oct 31, 2024
8ff795e
Merge branch 'bugfix-2.1.x' of https://github.com/MarlinFirmware/Marl…
classicrocker883 Nov 4, 2024
c4fbc09
revert settings.cpp
classicrocker883 Nov 4, 2024
7dfd495
ProUI updates
classicrocker883 Nov 9, 2024
f382068
revert some ProUI stuff
classicrocker883 Nov 9, 2024
9182086
Merge branch 'bugfix-2.1.x' of https://github.com/MarlinFirmware/Marl…
classicrocker883 Nov 13, 2024
953d2ac
Merge branch 'bugfix-2.1.x' of https://github.com/MarlinFirmware/Marl…
classicrocker883 Nov 21, 2024
8fd091a
Merge branch 'bugfix-2.1.x' of https://github.com/MarlinFirmware/Marl…
classicrocker883 Jan 12, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions Marlin/src/MarlinCore.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,8 @@
#include "lcd/e3v2/creality/dwin.h"
#elif ENABLED(DWIN_CREALITY_LCD_JYERSUI)
#include "lcd/e3v2/jyersui/dwin.h"
#elif ENABLED(DWIN_LCD_PROUI)
#include "lcd/extui/ui_api.h"
#elif ENABLED(SOVOL_SV06_RTS)
#include "lcd/sovol_rts/sovol_rts.h"
#endif
Expand Down Expand Up @@ -1622,13 +1624,13 @@ void setup() {
SERIAL_ECHO_TERNARY(err, "BL24CXX Check ", "failed", "succeeded", "!\n");
#endif

#if ENABLED(DWIN_CREALITY_LCD)
#if HAS_DWIN_E3V2_BASIC
SETUP_RUN(dwinInitScreen());
#elif ENABLED(SOVOL_SV06_RTS)
SETUP_RUN(rts.init());
#endif

#if HAS_SERVICE_INTERVALS && DISABLED(DWIN_CREALITY_LCD)
#if HAS_SERVICE_INTERVALS && !HAS_DWIN_E3V2_BASIC
SETUP_RUN(ui.reset_status(true)); // Show service messages or keep current status
#endif

Expand Down
5 changes: 3 additions & 2 deletions Marlin/src/gcode/bedlevel/abl/G29.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -873,7 +873,8 @@ G29_TYPE GcodeSuite::G29() {
else {
bedlevel.set_grid(abl.gridSpacing, abl.probe_position_lf);
COPY(bedlevel.z_values, abl.z_values);
TERN_(IS_KINEMATIC, bedlevel.extrapolate_unprobed_bed_level());
if (parser.boolval('K')) bedlevel.extrapolate_unprobed_bed_level();
else if (ENABLED(DWIN_LCD_PROUI) || ENABLED(IS_KINEMATIC)) bedlevel.extrapolate_unprobed_bed_level();
bedlevel.refresh_bed_level();

bedlevel.print_leveling_grid();
Expand Down Expand Up @@ -1009,7 +1010,7 @@ G29_TYPE GcodeSuite::G29() {
// Restore state after probing
if (!faux) restore_feedrate_and_scaling();

TERN_(HAS_BED_PROBE, probe.move_z_after_probing());
TERN_(Z_AFTER_PROBING, probe.move_z_after_probing());

#ifdef EVENT_GCODE_AFTER_G29
if (DEBUGGING(LEVELING)) DEBUG_ECHOLNPGM("After G29 G-code: ", EVENT_GCODE_AFTER_G29);
Expand Down
9 changes: 6 additions & 3 deletions Marlin/src/gcode/bedlevel/mbl/G29.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -84,8 +84,7 @@ void GcodeSuite::G29() {

TERN_(FULL_REPORT_TO_HOST_FEATURE, set_and_report_grblstate(M_PROBE));

int8_t ix, iy;
ix = iy = 0;
int8_t ix = 0, iy = 0;

switch (state) {
case MeshReport:
Expand Down Expand Up @@ -166,7 +165,11 @@ void GcodeSuite::G29() {
else {
// Save Z for the previous mesh position
bedlevel.set_zigzag_z(mbl_probe_index - 1, current_position.z);
TERN_(EXTENSIBLE_UI, ExtUI::onMeshUpdate(ix, iy, current_position.z));
#if ENABLED(DWIN_LCD_PROUI)
dwinPointUpdate(_MIN(mbl_probe_index, GRID_MAX_POINTS), int(GRID_MAX_POINTS), current_position.z);
#elif ENABLED(EXTENSIBLE_UI)
ExtUI::onMeshUpdate(ix, iy, current_position.z);
#endif
SET_SOFT_ENDSTOP_LOOSE(false);
}
// If there's another point to sample, move there with optional lift.
Expand Down
7 changes: 6 additions & 1 deletion Marlin/src/gcode/calibrate/M48.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,11 @@

void GcodeSuite::M48() {

if (homing_needed_error()) return;
#if ENABLED(DWIN_LCD_PROUI)
TERN_(ADVANCED_PAUSE_FEATURE, dwinPopupPause(GET_TEXT_F(MSG_M48_TEST));)
#endif

if (homing_needed_error()) TERN(DWIN_LCD_PROUI, return hmiReturnScreen(), return);

const int8_t verbose_level = parser.byteval('V', 1);
if (!WITHIN(verbose_level, 0, 4)) {
Expand Down Expand Up @@ -274,6 +278,7 @@ void GcodeSuite::M48() {
TERN_(HAS_PTC, ptc.set_enabled(true));

report_current_position();
TERN_(DWIN_LCD_PROUI, hmiReturnScreen();)
}

#endif // Z_MIN_PROBE_REPEATABILITY_TEST
2 changes: 1 addition & 1 deletion Marlin/src/gcode/gcode.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -309,7 +309,7 @@ void GcodeSuite::dwell(millis_t time) {
#endif
}

TERN_(HAS_DWIN_E3V2_BASIC, dwinLevelingDone());
TERN_(DWIN_CREALITY_LCD, dwinLevelingDone());
TERN_(EXTENSIBLE_UI, ExtUI::onLevelingDone());
}

Expand Down
4 changes: 2 additions & 2 deletions Marlin/src/gcode/lcd/M0_M1.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -63,14 +63,14 @@ void GcodeSuite::M0_M1() {
#endif
}

#elif ENABLED(DWIN_LCD_PROUI) // ExtUI with icon, string, button title
#elif ENABLED(DWIN_LCD_PROUI) // ProUI with icon, string, button title

if (parser.string_arg)
ExtUI::onUserConfirmRequired(ICON_Continue_1, parser.string_arg, GET_TEXT_F(MSG_USERWAIT));
else
ExtUI::onUserConfirmRequired(ICON_Stop_1, GET_TEXT_F(MSG_STOPPED), GET_TEXT_F(MSG_USERWAIT));

#elif ENABLED(EXTENSIBLE_UI)
#elif ENABLED(EXTENSIBLE_UI) // ExtUI with icon, string, button title

if (parser.string_arg)
ExtUI::onUserConfirmRequired(parser.string_arg); // String in an SRAM buffer
Expand Down
2 changes: 1 addition & 1 deletion Marlin/src/inc/Conditionals-5-post.h
Original file line number Diff line number Diff line change
Expand Up @@ -3132,7 +3132,7 @@
/**
* Bed Probe dependencies
*/
#if ANY(MESH_BED_LEVELING, HAS_BED_PROBE)
#if ANY(BABYSTEPPING, PROBE_SELECTED)
#ifndef PROBE_OFFSET_ZMIN
#define PROBE_OFFSET_ZMIN -20
#endif
Expand Down
1 change: 1 addition & 0 deletions Marlin/src/lcd/e3v2/common/dwin_set.h
Original file line number Diff line number Diff line change
Expand Up @@ -156,6 +156,7 @@
#define ICON_ProbeOffsetZ ICON_StepZ
#define ICON_PIDNozzle ICON_HotendTemp
#define ICON_PIDBed ICON_BedTemp
#define ICON_PIDChamber ICON_PrintSize
#define ICON_FWRetract ICON_StepE
#define ICON_FWRetLength ICON_StepE
#define ICON_FWRetSpeed ICON_Setspeed
Expand Down
6 changes: 3 additions & 3 deletions Marlin/src/lcd/e3v2/creality/dwin.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1114,9 +1114,9 @@ void popupWindowResume() {
dwinIconShow(ICON, ICON_Continue_C, 146, 307);
}
else {
dwinDrawString(true, font8x16, COLOR_POPUP_TEXT, COLOR_BG_WINDOW, (272 - 8 * 14) / 2, 115, F("Continue Print"));
dwinDrawString(true, font8x16, COLOR_POPUP_TEXT, COLOR_BG_WINDOW, (272 - 8 * 22) / 2, 192, F("It looks like the last"));
dwinDrawString(true, font8x16, COLOR_POPUP_TEXT, COLOR_BG_WINDOW, (272 - 8 * 21) / 2, 212, F("file was interrupted."));
dwinDrawString(true, font8x16, COLOR_POPUP_TEXT, COLOR_BG_WINDOW, (272 - 8 * 14) / 2, 115, GET_TEXT_F(MSG_OUTAGE_RECOVERY));
dwinDrawString(true, font8x16, COLOR_POPUP_TEXT, COLOR_BG_WINDOW, (272 - 8 * 22) / 2, 192, GET_TEXT_F(MSG_OUTAGE_RECOVERY2));
dwinDrawString(true, font8x16, COLOR_POPUP_TEXT, COLOR_BG_WINDOW, (272 - 8 * 21) / 2, 212, GET_TEXT_F(MSG_OUTAGE_RECOVERY3));
dwinIconShow(ICON, ICON_Cancel_E, 26, 307);
dwinIconShow(ICON, ICON_Continue_E, 146, 307);
}
Expand Down
Loading