Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

single line support added #3

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

alexm622
Copy link
Contributor

@alexm622 alexm622 commented Oct 23, 2021

fix #5
changes:

  • added a license comment delimiter that works for both single and multiline comment formats
  • added support for single line comment languages through the use of the
    constant SINGLE_LINE_COMMENTS in place of the postfix and uses the prefix as the comment
  • added .gitignore to remove any binaries and temporary testing files from the git path
  • added comments to utils/comments.go describing what type of file each of the lines corresponds to
  • updated SupportedFileExtensions in utils/constants.go to better follow the standards of "supported file extensions", but i can't seem to find a place where this is implemented

current issues

issue proposed solution
Makefiles still do not work due to the program matching based off of extension and Makefiles not having an extension a fix for this would be to rewrite the matching method to include full filenames, this would also have the side effect of being able to specify specific files in the config, which would then require a little more rewriting on matching the config file to the comment prefix/postfix in comments.go

@alexm622
Copy link
Contributor Author

alexm622 commented Oct 23, 2021

this will fail tests because of the new format of the license comments, meaning they'll have to be manually examined for this push and then the tests will have to be fixed as well
on another note this appears to have somehow fixed the issue with debug output

@alexm622
Copy link
Contributor Author

the last push removed unnecessary debug

@alexm622
Copy link
Contributor Author

alexm622 commented Nov 7, 2021

@Marvin9 the tests are not publicly included within the repository
that causes these new changes to fail the tests, a public inclusion of the tests would be beneficial, as the format of the licensing has been altered slightly to allow addition and removal of licenses in single line only languages

@Marvin9
Copy link
Owner

Marvin9 commented Nov 7, 2021

Hey @alexm622 Sorry, It's holiday time here therefore I couldn't spare time to review properly.

To make things clear can you please create new issue and explain what feature you want. After that, link this pull request to that issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for single line comment formats
2 participants