External log integration in report #987
Conversation
assert/assert-core/src/test/java/com/mastercard/test/flow/assrt/ReportCustomizerTest.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Changes look good, but I think there's a slight conflict in the naming of the types and methods:
ReportCustomizercan change any aspect of a flow's report data- The
motivationmethod that lets you add a customizer implies that only the flow motivations can be changed
I think it might be preferable to change ReportCustomizer to be MotivationCustomizer - have effectively it be a BiFunction<String, Assertion, String> that gets supplied with the motivation and the test results, and produces the new motivation.
I'm leaning in that direction rather than renaming the motivation method because we should try to limit the places where the report data can be changed. If you see unexpected results in a report you have to try and find out where it came from, if we can avoid the external log-linker thing being able to change (e.g.:) report message data then we've made that debugging a bit easier.
|
PR attempts to resolve #482