Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "storage: infrastructure for independent source output streams" #31037

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

def-
Copy link
Contributor

@def- def- commented Jan 14, 2025

Reverts #30858

Seems to cause https://github.com/MaterializeInc/database-issues/issues/8880

If it's hard to figure out what the cause is and fix it, would be prudent to revert for this release until it can be fixed properly.

Checklist

  • This PR has adequate test coverage / QA involvement has been duly considered. (trigger-ci for additional test/nightly runs)
  • This PR has an associated up-to-date design doc, is a design doc (template), or is sufficiently small to not require a design.
  • If this PR evolves an existing $T ⇔ Proto$T mapping (possibly in a backwards-incompatible way), then it is tagged with a T-proto label.
  • If this PR will require changes to cloud orchestration or tests, there is a companion cloud PR to account for those changes that is tagged with the release-blocker label (example).
  • If this PR includes major user-facing behavior changes, I have pinged the relevant PM to schedule a changelog post.

@def- def- requested review from petrosagg and jkosh44 January 14, 2025 16:23
@def- def- requested a review from a team as a code owner January 14, 2025 16:23
@def- def- requested a review from teskje January 14, 2025 16:23
@def- def- marked this pull request as draft January 14, 2025 16:28
@def-
Copy link
Contributor Author

def- commented Jan 14, 2025

Petros seems to have a fix, so back to draft and will close later if we don't need it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant