compute: consolidate AllowCompaction commands #31085
Draft
+40
−6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Defer the transmission of
AllowCompaction
commands to periodic controller maintenance, to reduce their volume and remove some noise from the command stream.This changes the behavior slightly in that
AllowCompaction
commands can now be delayed by up to 1s more than previously. I don't foresee this to be an issue.Motivation
Tips for reviewer
No strong feelings on whether we should merge this. On one hand, it's always good to try to be more efficient, and having a less noisy command stream makes it easier to identify anomalies. On the other hand I'm not aware of any issues caused by the current volume of compute commands and this change does add some additional complexity to the controller.
Checklist
$T ⇔ Proto$T
mapping (possibly in a backwards-incompatible way), then it is tagged with aT-proto
label.