Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Clean up potentially leftover state in case job was cancelled #31224

Merged
merged 1 commit into from
Jan 29, 2025
Merged

ci: Clean up potentially leftover state in case job was cancelled #31224

merged 1 commit into from
Jan 29, 2025

Conversation

def-
Copy link
Contributor

@def- def- commented Jan 29, 2025

Cancellation happened in https://buildkite.com/materialize/nightly/builds/10992#0194ae51-f610-4440-84f7-84fb30f17361 which resulted in leftover state making https://buildkite.com/materialize/nightly/builds/10995#0194ae83-c4ed-475a-8309-e8e6a5b80a02 not run

The usual cleanup logic can't be run even though it's in a finally block in our Python test code. The pre-exit hook is still being run.

Checklist

  • This PR has adequate test coverage / QA involvement has been duly considered. (trigger-ci for additional test/nightly runs)
  • This PR has an associated up-to-date design doc, is a design doc (template), or is sufficiently small to not require a design.
  • If this PR evolves an existing $T ⇔ Proto$T mapping (possibly in a backwards-incompatible way), then it is tagged with a T-proto label.
  • If this PR will require changes to cloud orchestration or tests, there is a companion cloud PR to account for those changes that is tagged with the release-blocker label (example).
  • If this PR includes major user-facing behavior changes, I have pinged the relevant PM to schedule a changelog post.

@def- def- requested review from jkosh44 and bobbyiliev January 29, 2025 10:57
@def- def- requested a review from a team as a code owner January 29, 2025 10:57
@def- def- enabled auto-merge January 29, 2025 11:11
@def- def- force-pushed the pr-terraform-cleanup branch from 4671e34 to b2dcd8d Compare January 29, 2025 11:11
@def-
ci: Clean up potentially leftover state in case job was cancelled
1e1eb50 
Happened in https://buildkite.com/materialize/nightly/builds/10992#0194ae51-f610-4440-84f7-84fb30f17361

The usual cleanup logic can't be run even though it's in a `finally`
block in our Python test code. The `pre-exit` hook is still being run.
@def- def- force-pushed the pr-terraform-cleanup branch from b2dcd8d to 1e1eb50 Compare January 29, 2025 11:12
@def- def- merged commit 9c6a3d0 into MaterializeInc:main Jan 29, 2025
81 checks passed
@def- def- deleted the pr-terraform-cleanup branch January 29, 2025 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkosh44 jkosh44 jkosh44 approved these changes

@bobbyiliev bobbyiliev Awaiting requested review from bobbyiliev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@def- @jkosh44