Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error messages #354

Merged
merged 1 commit into from
Nov 10, 2023
Merged

Improve error messages #354

merged 1 commit into from
Nov 10, 2023

Conversation

benesch
Copy link
Contributor

@benesch benesch commented Nov 10, 2023

Include detail and hint fields for conn execution errors. This is crucial for certain types of errors (e.g., unable to connect to PostgreSQL source), where the true cause of the error message is only returned in the detail field.

Include detail and hint fields for conn execution errors. This is
crucial for certain types of errors (e.g., unable to connect to
PostgreSQL source), where the true cause of the error message is only
returned in the detail field.
@benesch benesch requested review from dehume and morsapaes November 10, 2023 07:10
@benesch benesch requested a review from bobbyiliev as a code owner November 10, 2023 07:10
@benesch
Copy link
Contributor Author

benesch commented Nov 10, 2023

Before:

 Error: ERROR: failed to connect to PostgreSQL database (SQLSTATE XX000)

After:

 Error: ERROR: failed to connect to PostgreSQL database DETAIL: publication "noexist" does not exist (SQLSTATE XX000)

Copy link
Contributor

@morsapaes morsapaes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for handling this, @benesch.

Copy link
Contributor

@bobbyiliev bobbyiliev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@bobbyiliev bobbyiliev merged commit 24a381a into main Nov 10, 2023
4 checks passed
@bobbyiliev bobbyiliev deleted the errors branch November 10, 2023 12:34
bobbyiliev pushed a commit that referenced this pull request Nov 10, 2023
Include detail and hint fields for conn execution errors. This is
crucial for certain types of errors (e.g., unable to connect to
PostgreSQL source), where the true cause of the error message is only
returned in the detail field.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants