Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates to HTML build in CI #503

Merged
merged 4 commits into from
Mar 22, 2024
Merged

Updates to HTML build in CI #503

merged 4 commits into from
Mar 22, 2024

Conversation

ml-evs
Copy link
Member

@ml-evs ml-evs commented Mar 22, 2024 •
edited
Loading

This PR fixes the CI so that gh-pages does not include all future changes.

It also fixes the CSS following some feedback.

(Addresses #501)

develop now gets deployed to /specification/develop from the root of the page (currently optimade.org/OPTIMADE).

Still missing:

  • a list of deployed versions

@ml-evs ml-evs requested review from rartino, merkys and sauliusg March 22, 2024 09:07
merkys
merkys previously approved these changes Mar 22, 2024
View reviewed changes
Copy link
Member

@merkys merkys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it a lot that specific font names are no longer included! I did not attempt running the code in .github/workflows/pages.yml though.

@ml-evs ml-evs added the blocking-release This is a PR or issue that presently blocks the release of next version of the spec. label Mar 22, 2024
sauliusg
sauliusg approved these changes Mar 22, 2024
View reviewed changes
Copy link
Contributor

@sauliusg sauliusg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This branch now works great on my machine.

@rartino rartino merged commit bce1fc9 into develop Mar 22, 2024
5 checks passed
@rartino rartino deleted the ml-evs/update-html-build branch March 22, 2024 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sauliusg sauliusg sauliusg approved these changes

@merkys merkys merkys approved these changes

@rartino rartino rartino approved these changes

Assignees
No one assigned
Labels
blocking-release This is a PR or issue that presently blocks the release of next version of the spec.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ml-evs @rartino @merkys @sauliusg