update/fix validations #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mustafasoylu
added
bug
mustafasoylu
added a commit
that referenced
this pull request
Feb 5, 2025
commit b294b8c Author: Mustafa SOYLU <[email protected]> Date: Wed Jan 15 10:55:45 2025 +0100 bump version to 0.5.0 (#103) commit 9c87008 Author: Mustafa SOYLU <[email protected]> Date: Wed Jan 15 10:41:47 2025 +0100 update documentation (#94) * add notes * explain why set some fields as compulsory * Update README.md Co-authored-by: Volker Hofmann <[email protected]> --------- Co-authored-by: Volker Hofmann <[email protected]> commit 42ae9c2 Author: Mustafa SOYLU <[email protected]> Date: Wed Jan 15 10:41:23 2025 +0100 Optional email (#102) * make email optional in the person model * remove none's from the existing people list * make email optional in setuptools model * remove check of no email value since it is done in core now * update tests for optional email * show email is optional in manual * update doc dev docs for ruff usage commit d28180d Author: Mustafa Soylu <[email protected]> Date: Mon Jul 29 09:47:48 2024 +0200 fix version in readme commit 26dc24a Merge: f42047b f53acd6 Author: Mustafa SOYLU <[email protected]> Date: Mon Jul 29 09:34:36 2024 +0200 Merge pull request #93 from Materials-Data-Science-and-Informatics/release/v0.4.3 v0.4.3 commit f53acd6 Author: Mustafa Soylu <[email protected]> Date: Mon Jul 29 09:25:27 2024 +0200 update changelog and metadata commit f42047b Merge: a1548c9 78f8dc6 Author: Mustafa SOYLU <[email protected]> Date: Fri Jul 26 15:15:20 2024 +0200 Merge pull request #92 from Materials-Data-Science-and-Informatics/fix/validations update/fix validations commit 78f8dc6 Author: Mustafa Soylu <[email protected]> Date: Fri Jul 26 14:31:18 2024 +0200 fix test since person conversion fails returns none on error commit 4c81e63 Author: Mustafa Soylu <[email protected]> Date: Fri Jul 26 14:30:58 2024 +0200 check if person if None on the base class commit 993b714 Author: Mustafa Soylu <[email protected]> Date: Fri Jul 26 14:30:37 2024 +0200 return None if person conversion fails commit 188eda1 Author: Mustafa Soylu <[email protected]> Date: Tue Jul 23 16:01:51 2024 +0200 update changelog commit 023c33b Author: Mustafa Soylu <[email protected]> Date: Tue Jul 23 16:01:33 2024 +0200 add missing error type commit acd3dab Author: Mustafa Soylu <[email protected]> Date: Tue Jul 23 16:01:18 2024 +0200 disable error raise on users without email in julia commit 32ad110 Author: Mustafa Soylu <[email protected]> Date: Tue Jul 23 16:01:03 2024 +0200 disable error raise on users without email in package.json commit a400d97 Author: Mustafa Soylu <[email protected]> Date: Tue Jul 23 16:00:19 2024 +0200 disable error raise on users without email in poetry commit a1548c9 Merge: 6257f3a 324b4c3 Author: Mustafa SOYLU <[email protected]> Date: Tue Jul 23 11:55:24 2024 +0200 Merge pull request #91 from Materials-Data-Science-and-Informatics/feature/update_hooks update pre-commit hooks and dependencies commit 324b4c3 Author: Mustafa Soylu <[email protected]> Date: Tue Jul 23 11:41:52 2024 +0200 update dependencies commit 4bc902d Author: Mustafa Soylu <[email protected]> Date: Tue Jul 23 11:25:29 2024 +0200 update pre-commit hooks commit 6257f3a Merge: 77c9345 0972820 Author: Mustafa SOYLU <[email protected]> Date: Tue Apr 30 11:39:15 2024 +0200 Merge pull request #86 from Materials-Data-Science-and-Informatics/fix/log_format Fix/log format commit 0972820 Author: Mustafa Soylu <[email protected]> Date: Tue Apr 30 11:35:01 2024 +0200 bump version to 0.4.2 commit f02d8cf Author: Mustafa Soylu <[email protected]> Date: Tue Apr 30 11:29:25 2024 +0200 fix rich formating of error message and traceback commit 77c9345 Merge: 16dfb47 8be7dd2 Author: Mustafa SOYLU <[email protected]> Date: Mon Apr 8 17:54:07 2024 +0200 Merge pull request #82 from Materials-Data-Science-and-Informatics/fix/required_fields Fix/required fields commit 8be7dd2 Author: Mustafa Soylu <[email protected]> Date: Mon Apr 8 14:13:58 2024 +0200 bump version to 0.4.1 commit f48f5d3 Author: Mustafa Soylu <[email protected]> Date: Mon Apr 8 11:38:54 2024 +0200 fix package license commit 7bb381c Author: Mustafa Soylu <[email protected]> Date: Mon Apr 8 11:33:37 2024 +0200 fix mkdocs optional fields commit c9d2179 Author: Mustafa Soylu <[email protected]> Date: Mon Apr 8 11:33:21 2024 +0200 fix package json optional fields
mustafasoylu
added a commit
that referenced
this pull request
Feb 11, 2025
commit b294b8c Author: Mustafa SOYLU <[email protected]> Date: Wed Jan 15 10:55:45 2025 +0100 bump version to 0.5.0 (#103) commit 9c87008 Author: Mustafa SOYLU <[email protected]> Date: Wed Jan 15 10:41:47 2025 +0100 update documentation (#94) * add notes * explain why set some fields as compulsory * Update README.md Co-authored-by: Volker Hofmann <[email protected]> --------- Co-authored-by: Volker Hofmann <[email protected]> commit 42ae9c2 Author: Mustafa SOYLU <[email protected]> Date: Wed Jan 15 10:41:23 2025 +0100 Optional email (#102) * make email optional in the person model * remove none's from the existing people list * make email optional in setuptools model * remove check of no email value since it is done in core now * update tests for optional email * show email is optional in manual * update doc dev docs for ruff usage commit d28180d Author: Mustafa Soylu <[email protected]> Date: Mon Jul 29 09:47:48 2024 +0200 fix version in readme commit 26dc24a Merge: f42047b f53acd6 Author: Mustafa SOYLU <[email protected]> Date: Mon Jul 29 09:34:36 2024 +0200 Merge pull request #93 from Materials-Data-Science-and-Informatics/release/v0.4.3 v0.4.3 commit f53acd6 Author: Mustafa Soylu <[email protected]> Date: Mon Jul 29 09:25:27 2024 +0200 update changelog and metadata commit f42047b Merge: a1548c9 78f8dc6 Author: Mustafa SOYLU <[email protected]> Date: Fri Jul 26 15:15:20 2024 +0200 Merge pull request #92 from Materials-Data-Science-and-Informatics/fix/validations update/fix validations commit 78f8dc6 Author: Mustafa Soylu <[email protected]> Date: Fri Jul 26 14:31:18 2024 +0200 fix test since person conversion fails returns none on error commit 4c81e63 Author: Mustafa Soylu <[email protected]> Date: Fri Jul 26 14:30:58 2024 +0200 check if person if None on the base class commit 993b714 Author: Mustafa Soylu <[email protected]> Date: Fri Jul 26 14:30:37 2024 +0200 return None if person conversion fails commit 188eda1 Author: Mustafa Soylu <[email protected]> Date: Tue Jul 23 16:01:51 2024 +0200 update changelog commit 023c33b Author: Mustafa Soylu <[email protected]> Date: Tue Jul 23 16:01:33 2024 +0200 add missing error type commit acd3dab Author: Mustafa Soylu <[email protected]> Date: Tue Jul 23 16:01:18 2024 +0200 disable error raise on users without email in julia commit 32ad110 Author: Mustafa Soylu <[email protected]> Date: Tue Jul 23 16:01:03 2024 +0200 disable error raise on users without email in package.json commit a400d97 Author: Mustafa Soylu <[email protected]> Date: Tue Jul 23 16:00:19 2024 +0200 disable error raise on users without email in poetry commit a1548c9 Merge: 6257f3a 324b4c3 Author: Mustafa SOYLU <[email protected]> Date: Tue Jul 23 11:55:24 2024 +0200 Merge pull request #91 from Materials-Data-Science-and-Informatics/feature/update_hooks update pre-commit hooks and dependencies commit 324b4c3 Author: Mustafa Soylu <[email protected]> Date: Tue Jul 23 11:41:52 2024 +0200 update dependencies commit 4bc902d Author: Mustafa Soylu <[email protected]> Date: Tue Jul 23 11:25:29 2024 +0200 update pre-commit hooks commit 6257f3a Merge: 77c9345 0972820 Author: Mustafa SOYLU <[email protected]> Date: Tue Apr 30 11:39:15 2024 +0200 Merge pull request #86 from Materials-Data-Science-and-Informatics/fix/log_format Fix/log format commit 0972820 Author: Mustafa Soylu <[email protected]> Date: Tue Apr 30 11:35:01 2024 +0200 bump version to 0.4.2 commit f02d8cf Author: Mustafa Soylu <[email protected]> Date: Tue Apr 30 11:29:25 2024 +0200 fix rich formating of error message and traceback commit 77c9345 Merge: 16dfb47 8be7dd2 Author: Mustafa SOYLU <[email protected]> Date: Mon Apr 8 17:54:07 2024 +0200 Merge pull request #82 from Materials-Data-Science-and-Informatics/fix/required_fields Fix/required fields commit 8be7dd2 Author: Mustafa Soylu <[email protected]> Date: Mon Apr 8 14:13:58 2024 +0200 bump version to 0.4.1 commit f48f5d3 Author: Mustafa Soylu <[email protected]> Date: Mon Apr 8 11:38:54 2024 +0200 fix package license commit 7bb381c Author: Mustafa Soylu <[email protected]> Date: Mon Apr 8 11:33:37 2024 +0200 fix mkdocs optional fields commit c9d2179 Author: Mustafa Soylu <[email protected]> Date: Mon Apr 8 11:33:21 2024 +0200 fix package json optional fields
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update poetry, package.json and julia models and writer for person validation. Now, we dont raise an error when the person doesnt have email information, we ignore that input and print a warning message. This also fixes #87
closes #87