Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing time constrained more #1165

Merged
merged 5 commits into from
Nov 12, 2024
Merged

Conversation

rocky
Copy link
Member

@rocky rocky commented Nov 12, 2024

No description provided.

See discusion.

* use range() instead of while
* improve docstring on Pause[]
* Correct with_traceback function call
@rocky rocky requested a review from mmatera November 12, 2024 22:58
@rocky rocky changed the base branch from master to fixing_TimeConstrained November 12, 2024 22:58
Copy link
Contributor

@mmatera mmatera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM

* Make explicit ticks-per-second magic number
* Fix another with_traceback call
* Revise docstrings
@rocky
Copy link
Member Author

rocky commented Nov 12, 2024

@mmatera one last commit of changes. If you are okay with these further changes, I think we can merge everything back into the master branch.

Copy link
Contributor

@mmatera mmatera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rocky rocky merged commit 0010488 into fixing_TimeConstrained Nov 12, 2024
8 checks passed
@rocky rocky deleted the fixing_TimeConstrained-more branch November 12, 2024 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants