Go over Breakpoint[] documentation ... #1193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a docstring to disabled_breakpoint
rocky
force-pushed
the
Breakpoint-tweaks
branch
from
2008e34 to
114d7f0
Compare
Co-authored-by: Aravindh Krishnamoorthy <[email protected]>
Co-authored-by: Aravindh Krishnamoorthy <[email protected]>
mathics/builtin/system.py
Outdated
| Note that setting '$MaxLengthIntStringConversion' has an effect only on Python 3.11 and later; | ||
| Pyston 2.x however ignores this. | ||
| Mathics3 also provides "breakpoint" handler 'mathics.disabled_breakpoint' which \ | ||
| notes that a 'Breakpoint[]' was encountered, but does not stop inside Python. \ |
There was a problem hiding this comment.
Suggested change
| notes that a 'Breakpoint[]' was encountered, but does not stop inside Python. \ | |
| notes that a breakpoint was encountered, but does not stop inside Python. \ |
The breakpoint could be, e.g., reached due to a break debugger command as well.
There was a problem hiding this comment.
A debugger break would not trigger this. Adding to the source code breakpoint() would though. I will revise.
|
Looks good to me as well... |
Co-authored-by: Aravindh Krishnamoorthy <[email protected]>
Co-authored-by: Aravindh Krishnamoorthy <[email protected]>
|
It looks like If there are further changes to the text or behavior feel free to continue this in a new PR. Thanks everyone for the reviews. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and add a docstring to disabled_breakpoint