Add asymptote-formatted dodecahedron, icosahedron, octahedron and tetrahedron #1345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmatera
reviewed
Feb 2, 2025
|
|
||
| <dl> | ||
| <dt>'Dodecahedron[]' | ||
| <dd>a regular dodecahedron centered at the origin with unit edge length. | ||
|
|
||
| <dt>'Dodecahedron[$l$]' |
There was a problem hiding this comment.
It is "l" for length. See https://reference.wolfram.com/language/ref/Dodecahedron.html or the "dd" description.
mmatera
reviewed
Feb 2, 2025
| <dt>'Dodecahedron[$l$]' | ||
| <dd>a regular dodecahedron centered at the origin with edge length $l$. | ||
|
|
||
| <dt>'Dodecahedron[{$x$, $y$, $z$}, ...]' |
There was a problem hiding this comment.
There was a problem hiding this comment.
Ok. Good. Docstrings have been revised here.
mmatera
reviewed
Feb 2, 2025
| <dd>a regular dodecahedron centered at the origin with edge length $l$. | ||
|
|
||
| <dt>'Dodecahedron[{$x$, $y$, $z$}, ...]' | ||
| <dd>a regular dodecahedron centered at {$x$ $y$, $z$}. |
rocky
force-pushed
the
add-asy-dodecahedron
branch
from
517b4c8 to
5740dde
Compare
|
Notice that now the format of the docstrings is checked by the consistency tests. |
rocky
force-pushed
the
add-asy-dodecahedron
branch
from
1db94c4 to
eb8ca09
Compare
|
I will be adding octahedron soon. |
rocky
changed the title
rocky
force-pushed
the
add-asy-dodecahedron
branch
11 times, most recently
from
526d563 to
4dc7012
Compare
mmatera
reviewed
Feb 3, 2025
| @@ -42,12 +80,21 @@ class Dodecahedron(Builtin): | |||
|
|
|||
| class Icosahedron(Builtin): | |||
| """ | |||
| <url>:WMA link: | |||
| https://reference.wolfram.com/language/ref/Icosahedron.html</url> | |||
| <url>:Icosahedron: | |||
There was a problem hiding this comment.
This still produces a sphere in ASY
There was a problem hiding this comment.
Yep. This is the last one to do.
rocky
changed the title
Use a less bright light.
split off asymptote polyhedra code
Use a less bright light.
split off asymptote polyhedra code
Add cube
rocky
force-pushed
the
add-asy-dodecahedron
branch
from
1999ddb to
b5a8435
Compare
rocky
force-pushed
the
add-asy-dodecahedron
branch
from
b5a8435 to
cf0513e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.