Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Account for deprecated scipy simps function and numpy datatypes #52

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

GregoryPetrochenkov-NOAA
Copy link

@GregoryPetrochenkov-NOAA GregoryPetrochenkov-NOAA commented Oct 21, 2024

I went ahead and added an import for the new simpson function in the integrate model of scipy (formerly simps). In case the scipy version is old enough to have simps it will revert to that function. I also removed references to np.float_ and np.int_.

Changed

  • reliability/Distributions.py: Added a try import from the newer integrate.simpson method, import integrate.simps if this fails
  • reliability/Other_Functions.py: Removed data types that result in problems for updated version of numpy.

All unit tests passed locally as well with a default install of dependencies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant