Skip to content

Commit

Permalink
[SPARK-51039][BUILD] Fix hive-llap-common dependency to use `hive.l…
Browse files Browse the repository at this point in the history
…lap.scope` in root `pom.xml`

### What changes were proposed in this pull request?

This PR aims to fix `hive-llap-common` dependency to use `hive.llap.scope` in root pom for Apache Spark 3.5 and 4.0.

### Why are the changes needed?

Apache Spark has been supposed to use `hive.llap.scope` for `hive-llap-common` dependency and `hive` module do it correctly.
https://github.com/apache/spark/blob/a1b0f256c04e5b632075358d1e2f946e64588da6/sql/hive/pom.xml#L119-L123

Since Apache Spark 3.0.0 (SPARK-27176), the root `pom.xml` file has been using a wrong scope mistakenly. Probably, it's due to `-Phive-provided` support. This causes a confusion to other external systems and the users. We had better fix the root `pom.xml` to use `hive.llap.scope` correctly.
- apache#23788

### Does this PR introduce _any_ user-facing change?

No, there is no change technically because `hive` module has been using a correct scope.

### How was this patch tested?

Pass the CIs.

### Was this patch authored or co-authored using generative AI tooling?

No.

Closes apache#49733 from dongjoon-hyun/SPARK-51039.

Authored-by: Dongjoon Hyun <[email protected]>
Signed-off-by: Dongjoon Hyun <[email protected]>
  • Loading branch information
dongjoon-hyun committed Jan 30, 2025
1 parent 9e1bfa1 commit 7243de6
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
1 change: 1 addition & 0 deletions assembly/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -323,6 +323,7 @@
<id>hive-provided</id>
<properties>
<hive.deps.scope>provided</hive.deps.scope>
<hive.llap.scope>provided</hive.llap.scope>
<hive.jackson.scope>provided</hive.jackson.scope>
</properties>
</profile>
Expand Down
2 changes: 1 addition & 1 deletion pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -2255,7 +2255,7 @@
<groupId>${hive.group}</groupId>
<artifactId>hive-llap-common</artifactId>
<version>${hive.version}</version>
<scope>${hive.deps.scope}</scope>
<scope>${hive.llap.scope}</scope>
<exclusions>
<exclusion>
<groupId>${hive.group}</groupId>
Expand Down

0 comments on commit 7243de6

Please sign in to comment.