Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Entity overhaul #47

Merged
merged 38 commits into from
May 2, 2021
Merged

Entity overhaul #47

merged 38 commits into from
May 2, 2021

Conversation

MaxIsJoe
Copy link
Owner

@MaxIsJoe MaxIsJoe commented Apr 28, 2021 •
edited
Loading

closes #44

suddenly found my self working on #39 while doing this lol. nice.

Makes all characters including the player share a single entity scene that can be extended with different logic and behavior.

@MaxIsJoe MaxIsJoe self-assigned this Apr 28, 2021
@MaxIsJoe MaxIsJoe marked this pull request as draft April 28, 2021 13:00
@MaxIsJoe MaxIsJoe marked this pull request as ready for review May 1, 2021 20:05
@MaxIsJoe
Copy link
Owner Author

MaxIsJoe commented May 1, 2021

Technically this is done.
There is a couple issues with NPC positioning on the map and not having the ability to spawn the context menus on right click yet so I'll fix them then merge this later.

@MaxIsJoe MaxIsJoe merged commit 8a4ee42 into master May 2, 2021
@MaxIsJoe MaxIsJoe deleted the EntityOverhaul branch May 2, 2021 03:00
@MaxIsJoe MaxIsJoe mentioned this pull request May 2, 2021
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@MaxIsJoe MaxIsJoe

Labels
Godot Improvment networking NPCs Player Scenes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[0.0.2] Create a base entity node for all characters (including the player)
1 participant
@MaxIsJoe