Move programs from mbedtls to framework #9939
Open
+55
−962
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Harry-Ramsey
force-pushed
the
move-programs-from-mbedtls-to-framework
branch
3 times, most recently
from
febf47b to
fab23f5
Compare
ronald-cron-arm
requested changes
Feb 6, 2025
Harry-Ramsey
force-pushed
the
move-programs-from-mbedtls-to-framework
branch
3 times, most recently
from
f9326e3 to
4070f50
Compare
ronald-cron-arm
requested changes
Feb 12, 2025
Harry-Ramsey
force-pushed
the
move-programs-from-mbedtls-to-framework
branch
13 times, most recently
from
65afcd8 to
88d1a72
Compare
This was referenced Feb 17, 2025
Harry-Ramsey
force-pushed
the
move-programs-from-mbedtls-to-framework
branch
2 times, most recently
from
6b097cc to
75a4c60
Compare
Harry-Ramsey
force-pushed
the
move-programs-from-mbedtls-to-framework
branch
2 times, most recently
from
30dc690 to
18ccaf8
Compare
Harry-Ramsey
force-pushed
the
move-programs-from-mbedtls-to-framework
branch
from
f2e8213 to
d7adaac
Compare
ronald-cron-arm
requested changes
Feb 18, 2025
ronald-cron-arm
requested changes
Feb 18, 2025
There was a problem hiding this comment.
I've done a complete review now. Only one blocker: #9939 (comment). Otherwise some doc updates needed.
Harry-Ramsey
force-pushed
the
move-programs-from-mbedtls-to-framework
branch
3 times, most recently
from
0283fe8 to
e0435b6
Compare
ronald-cron-arm
requested changes
Feb 19, 2025
There was a problem hiding this comment.
Just one comment that has not been fully addressed (#9939 (comment)) (note that there is a TF-PSA-Crypto part to it) otherwise this looks good to me.
ronald-cron-arm
requested changes
Feb 19, 2025
Harry-Ramsey
force-pushed
the
move-programs-from-mbedtls-to-framework
branch
2 times, most recently
from
602ad60 to
de8547a
Compare
ronald-cron-arm
requested changes
Feb 19, 2025
Harry-Ramsey
force-pushed
the
move-programs-from-mbedtls-to-framework
branch
from
de8547a to
20a1edd
Compare
This commit moves demo_common.sh, dlopen_demo.sh, metatest.c query_compile_time_config.c, query_config.h, query_included_headers.c, zeroize.c and test_zeroize.gdb from MbedTLS into the MbedTLS framework. Signed-off-by: Harry Ramsey <[email protected]>
This commit updates the file paths necessary for dlopen_demo.sh, metatest.c query_compile_time_config.c, query_config.h, query_included_headers.c and zeroize.c. This commit also adds a CFLAG to find header files now contained in the framework. Signed-off-by: Harry Ramsey <[email protected]>
Signed-off-by: Harry Ramsey <[email protected]>
This commit fixes the paths of program files which were moved to the MbedTLS Framework. Signed-off-by: Harry Ramsey <[email protected]>
This commit updates the paths for dlopen_demo.sh in components-build-system.sh as the file has been moved to the framework. Signed-off-by: Harry Ramsey <[email protected]>
This commit updates the paths for moved programs in generate_visualc_files.pl. Signed-off-by: Harry Ramsey <[email protected]>
This commit updates the path for the moved test_zeroize.gdb script which has been moved to MbedTLS-Framework. Signed-off-by: Harry Ramsey <[email protected]>
This commit updates the paths in documentation for test_zeroize since it has been moved to MbedTLS Framework. Signed-off-by: Harry Ramsey <[email protected]>
This commit updates the paths in the documentation for metatest.c as it has been moved to MbedTLS Framework. Signed-off-by: Harry Ramsey <[email protected]>
Harry-Ramsey
force-pushed
the
move-programs-from-mbedtls-to-framework
branch
from
20a1edd to
e8f5c6e
Compare
Signed-off-by: Harry Ramsey <[email protected]>
Signed-off-by: Harry Ramsey <[email protected]>
Harry-Ramsey
force-pushed
the
move-programs-from-mbedtls-to-framework
branch
from
e8f5c6e to
5befe36
Compare
valeriosetti
approved these changes
Feb 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Move program files to MbedTLS-Framework. Closes #112.
PR checklist