Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update messages.en.yaml #1431

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

TheVillageGuy
Copy link
Contributor

Shorten subscribe/unsubscribe to prevent buttons forming two rows

Shorten subscribe/unsubscribe to prevent buttons forming two rows
@melroy89

This comment was marked as outdated.

@melroy89
Copy link
Member

melroy89 commented Feb 6, 2025

Also we might still want to show the full line "Subscribe" and "Unsubscribe" to the users when they mouse-over the button, using the HTML title tag. Hence it might be better to create a new translation strings for the abbreviations.

@BentiGorlich
Copy link
Member

@TheVillageGuy some tests do use text to recognize some buttons so when you change it it will not find those buttons anymore and then you'll get errors like "current node list is empty".
When you go to the failed pipeline you will get the test errors with the files they originate from. Then you can fix them

@TheVillageGuy
Copy link
Contributor Author

Also we might still want to show the full line "Subscribe" and "Unsubscribe" to the users when they mouse-over the button, using the HTML title tag. Hence it might be better to create a new translation strings for the abbreviations.

Good point, I'll add them soon.

@BentiGorlich I'm going to have to figure out how those tests work then, that's going to take some time

@TheVillageGuy TheVillageGuy marked this pull request as draft February 11, 2025 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants