Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Qt GUI: Add Conformance glossary button #1038

Merged
merged 1 commit into from
Feb 23, 2025

Conversation

cjee21
Copy link
Collaborator

@cjee21 cjee21 commented Feb 22, 2025

Just remembered there is this button. Now Qt GUI also has it though the webpage that the button leads to appears to have nothing.

Screenshot 2025-02-22 175734

@cjee21 cjee21 force-pushed the Qt-conformance-btn branch from 561f4af to c9fd8f5 Compare February 22, 2025 10:24
@JeromeMartinez
Copy link
Member

Checking the changes, do Qt translation files change so much each time you add a line of code? It is creating a strong dependency of commits and also a big Git log for any small change...
I was already not happy with the VCL translation files (too big, too many change for any translation) but now it becomes even bigger (translation files update even with translation update) :(.

@JeromeMartinez
Copy link
Member

appears to have nothing.

It is currently broken, I need to fix that ASAP.

@cjee21
Copy link
Collaborator Author

cjee21 commented Feb 22, 2025

Checking the changes, do Qt translation files change so much each time you add a line of code? It is creating a strong dependency of commits and also a big Git log for any small change... I was already not happy with the VCL translation files (too big, too many change for any translation) but now it becomes even bigger (translation files update even with translation update) :(.

Other than the new string for the button, the lines of code changes but even if those are wrong the app still works. I think that is for Qt Linguist so that it can show where the string comes from for translators to refer.

Maybe we remove translation files from git and generate them on every build?

@JeromeMartinez
Copy link
Member

Maybe we remove translation files from git and generate them on every build?

I think so. Actually also for the big all in one file (I actually use it only as an intermediate file) but the code for creating it is awful, on my todo list. And same for the macOS translation files. In the meantime, having a script for creating the the Qt translation files may be better and a first step in the expected direction for the source code.

@cjee21
Copy link
Collaborator Author

cjee21 commented Feb 22, 2025

But the generation script will have to work cross-platform in that case... 🤔

@JeromeMartinez
Copy link
Member

But the generation script will have to work cross-platform in that case... 🤔

For the first langage files (the csv ones), I use... C++ as crossplatform script :).

@cjee21 cjee21 force-pushed the Qt-conformance-btn branch from c9fd8f5 to 6a82fb9 Compare February 22, 2025 16:08
@cjee21 cjee21 force-pushed the Qt-conformance-btn branch from 6a82fb9 to 90de5a8 Compare February 23, 2025 13:55
@cjee21
Copy link
Collaborator Author

cjee21 commented Feb 23, 2025

Rebased

@JeromeMartinez JeromeMartinez merged commit bb23c6b into MediaArea:master Feb 23, 2025
8 checks passed
@cjee21 cjee21 deleted the Qt-conformance-btn branch February 23, 2025 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants