Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Qt GUI: Remove translations files from Git and generate them before build instead + remove WebView2 SDK version dependency #1039

Merged
merged 6 commits into from
Feb 23, 2025

Conversation

cjee21
Copy link
Collaborator

@cjee21 cjee21 commented Feb 22, 2025

No description provided.

@JeromeMartinez
Copy link
Member

Thank you for taking care about the translation update issue.
Is it difficult to avoid to rely on a very specific version of Qt?

@cjee21
Copy link
Collaborator Author

cjee21 commented Feb 23, 2025

Is it difficult to avoid to rely on a very specific version of Qt?

There should be no problem building it with different versions of Qt though recently I only tested with latest. Just that need at least 6.5 for Windows dark mode support and 6.8 for official MSVC2022 (the older one with MSVC2019 is actually compatible with MSVC2022 too).

For the CI, the reason for the version hardcode is due to the path to some Qt executables contain the version.
Improved in force push below. No more using specific version.

@cjee21
Copy link
Collaborator Author

cjee21 commented Feb 23, 2025

I'll modify CI with a variable for version so that easier to change.

@cjee21 cjee21 changed the title Qt GUI: Remove translations files from Git and generate them before build instead Qt GUI: Remove translations files from Git and generate them before build instead + fix version of Edge WebView2 SDK used Feb 23, 2025
@cjee21 cjee21 marked this pull request as draft February 23, 2025 12:26
@cjee21 cjee21 changed the title Qt GUI: Remove translations files from Git and generate them before build instead + fix version of Edge WebView2 SDK used Qt GUI: Remove translations files from Git and generate them before build instead + remove WebView2 SDK version dependency Feb 23, 2025
@cjee21 cjee21 marked this pull request as ready for review February 23, 2025 13:08
@cjee21
Copy link
Collaborator Author

cjee21 commented Feb 23, 2025

Removed version dependencies for Qt and WebView2. Now only one env var in CI for Qt version that is set to latest version of Qt 6 which results in using the pre-release 6.9.0 currently.

@JeromeMartinez
Copy link
Member

Removed version dependencies for Qt and WebView2.

Thank you.

Now only one env var in CI for Qt version that is set to latest version of Qt 6 which results in using the pre-release 6.9.0 currently.

Totally fine (and better, actually, no need of any manual update and we anticipate issues).

@JeromeMartinez JeromeMartinez merged commit 1b7566c into MediaArea:master Feb 23, 2025
8 checks passed
@cjee21 cjee21 deleted the Qt branch February 23, 2025 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants