Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: support container image SHA256 version #1248

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rollandf
Copy link
Member

@rollandf rollandf commented Jan 8, 2025

In OCP disconnected environment, the mirrored images are not using tags but SHA256.

This change support boths format in the NCP except for DOCA-Driver.

@coveralls
Copy link
Collaborator

coveralls commented Jan 8, 2025

Pull Request Test Coverage Report for Build 12678523150

Details

  • 5 of 5 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.2%) to 60.504%

Totals Coverage Status
Change from base Build 12669587562: 0.2%
Covered Lines: 3338
Relevant Lines: 5517

💛 - Coveralls

@rollandf rollandf force-pushed the version-validation branch from 96b30f1 to bd84c13 Compare January 8, 2025 19:01
In OCP disconnected environment, the mirrored images
are not using tags but SHA256.

This change support boths format in the NCP except for DOCA-Driver.

Signed-off-by: Fred Rolland <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants