Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Update tap setting metadata #185

Merged
merged 2 commits into from
Dec 4, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions meltano.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,7 @@ plugins:
extractors:
- name: tap-athena
namespace: tap_athena
# TODO: To test using Meltano, replace with absolute path
# to the tap-athena.sh script:
executable: ./tap-athena.sh
executable: -e .
capabilities:
- state
- catalog
Expand All @@ -16,9 +14,11 @@ plugins:
# start_date: '2010-01-01T00:00:00Z'
settings:
- name: aws_access_key_id
kind: password
kind: string
sensitive: true
- name: aws_secret_access_key
kind: password
kind: string
sensitive: true
- name: aws_region
kind: string
- name: s3_staging_dir
Expand Down
9 changes: 8 additions & 1 deletion tap_athena/tap.py
Original file line number Diff line number Diff line change
Expand Up @@ -19,30 +19,37 @@ class TapAthena(SQLTap):
"aws_access_key_id",
th.StringType,
required=True,
secret=True,
title="AWS Access Key ID",
description="AWS access key ID",
),
th.Property(
"aws_secret_access_key",
th.StringType,
required=True,
secret=True,
title="AWS Secret Access Key",
description="AWS secret access key",
),
th.Property(
"aws_region",
th.StringType,
required=True,
description="AWS region",
title="AWS region",
description="The AWS region",
),
th.Property(
"s3_staging_dir",
th.StringType,
required=True,
title="S3 staging directory",
description="The S3 staging directory where output is written.",
),
th.Property(
"schema_name",
th.StringType,
required=True,
title="Schema Name",
description="Athena schema name",
),
).to_dict()
Expand Down
Loading