-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove State Capability #11
Comments
@pnadolny13 - Good call. I'd say as a short term fix, we probably can go ahead and remove the capability. In regards to how we might implement state tracking, I think we have two approaches which are very different from each other:
|
@aaronsteers I agree. I created #12 to remove the capability for now. I see value in both options but I think its more common for people to use this tap for testing out pipelines vs running large workloads so reading the whole file isnt that big of a deal. I'd vote for options 2 by default but potentially supporting both options as a configurable switch - idk if thats possible or if it would cause problems though. |
@pnadolny13 - Yes, agreed. I think the SDK "rails" have an apply_catalog() method which would apply "replication_key" if provided by a user in the catalog. That said, it's untested as of now and might need some adjustment. There might even by built-in capability to exclude values based on that key's If you have cycles (and interest) to try this out, I'd be interested to know if it works out of box - or if it needs more work. |
Closing because I split the implementation to a separate issue. #13 |
Currently state is a listed capability but we dont bookmark files. Try to implement state tracking for files in an OS agnostic way.
Or just remove the state capability from the README and MeltanoHub and note that it doesnt manage state.
The text was updated successfully, but these errors were encountered: