Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove state capability #12

Merged
merged 1 commit into from
Feb 2, 2022
Merged

remove state capability #12

merged 1 commit into from
Feb 2, 2022

Conversation

pnadolny13
Copy link
Collaborator

No description provided.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 2, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@pnadolny13 pnadolny13 mentioned this pull request Feb 2, 2022
Closed
aaronsteers
aaronsteers approved these changes Feb 2, 2022
View reviewed changes
Copy link
Contributor

@aaronsteers aaronsteers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@aaronsteers
Copy link
Contributor

@pnadolny13 - I realized when writing this that the capability might already be built in. Might be worth confirming if this approach works (or not) before merging this: #11 (comment)

@aaronsteers
Copy link
Contributor

@pnadolny13 - Disregard my comment above. As noted in the related issue:

@pnadolny13 - Quick update: I checked the source code here and it looks like exclusion is not handled in any default implementation aspects. Configuration via apply_catalog() is handled, I think, but not filtering of records.

@pnadolny13 pnadolny13 merged commit ac02c9d into main Feb 2, 2022
@pnadolny13 pnadolny13 deleted the remove_state_capability branch February 3, 2022 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aaronsteers aaronsteers aaronsteers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pnadolny13 @aaronsteers