-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Update tap to use the LinkedIn 202305 API #68
Conversation
Have fixes to 3 streams and client.py
Added back get_next_page_token. Partial fix to parse_response
parse_response fix
…group and creative properties
LinkedIn 202305 updates
This reverts commit 79cb560.
Updated Tests, get_next_page_token
Hey @kgpayne, The pytests are failing with a 401 error for path/adAccounts. This doesn't appear to be an issue in the code, because tests are passing without this error from the fork we are merging from. Any thoughts on why that could be? We have resolved the errors in the Pre-commit CI job |
@NeilGorman104 That indeed seems not to be caused by the changes in this PR and I'm seeing it in other PRs (#73). Since the failure doesn't seem to be caused by any code changes I guess it's related to changes in the permissions for the access token that was saved in this repo as a secret. Can you confirm that the access token didn't change? |
@edgarrmondragon It looks like our LinkedIn access token just expired. I'll generate a new token and add it to the secrets for the repo. The access token was active when this test ran so I'm not sure whether or not it was an issue with the token being wrong |
Hey @edgarrmondragon I have updated this repo and my fork with a newly generated access token. However, we are still facing the 401 error on the PR but my fork is still running the pytest without errors. I am continuing to look into this. Do you know of any reasons that the same test would be giving different results across repos with the same secrets? |
@NeilGorman104 I can see in the workflow logs that the secret is not being used, but that's probably because we're merging from a fork because I can confirm the new token works fine in other PRs 👍 |
@NeilGorman104 This LGTM. If you're not planning to push more changes, we can merge this. |
@edgarrmondragon Sounds good, merging this now |
Updates the LinkedIn tap to use the 202305 version
Note: The pytests are failing with a 401 error for path/adAccounts. This doesn't appear to be an issue in the code, because tests are passing without this error from the fork we are merging from