Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Update tap to use the LinkedIn 202305 API #68

Merged
merged 37 commits into from
Jul 6, 2023

Conversation

NeilGorman104
Copy link
Collaborator

@NeilGorman104 NeilGorman104 commented Jun 13, 2023

Updates the LinkedIn tap to use the 202305 version

  1. Sets the default LinkedIn-version to 202305
  2. Updates the Campaign, CampaignGroup, and Creatives streams request bodies to match new request format
  3. Updates AdAnalytics stream: Removes deprecated pivotvalue and replaces method of getting adanalytics IDs using configs
  4. Updates parse_response and post_process functions to handle data coming from both updated streams and streams unaffected by update
  5. Adds New campaign_group and creative properties to tap.py and .env.template
  6. Updates ReadMe to reflect changes in settings
  7. Updates get_next_page_token to remove try/except statement
  8. Resolves errors in pre-commit job

Note: The pytests are failing with a 401 error for path/adAccounts. This doesn't appear to be an issue in the code, because tests are passing without this error from the fork we are merging from

tap_linkedin_ads/tap.py Outdated Show resolved Hide resolved
tap_linkedin_ads/tap.py Outdated Show resolved Hide resolved
tap_linkedin_ads/tap.py Outdated Show resolved Hide resolved
meltano.yml Outdated Show resolved Hide resolved
@NeilGorman104
Copy link
Collaborator Author

NeilGorman104 commented Jul 1, 2023

Hey @kgpayne, The pytests are failing with a 401 error for path/adAccounts. This doesn't appear to be an issue in the code, because tests are passing without this error from the fork we are merging from. Any thoughts on why that could be?

We have resolved the errors in the Pre-commit CI job

@edgarrmondragon
Copy link
Member

Hey @kgpayne, The pytests are failing with a 401 error for path/adAccounts. This doesn't appear to be an issue in the code, because tests are passing without this error from the fork we are merging from. Any thoughts on why that could be?

We have resolved the errors in the Pre-commit CI job

@NeilGorman104 That indeed seems not to be caused by the changes in this PR and I'm seeing it in other PRs (#73).

Since the failure doesn't seem to be caused by any code changes I guess it's related to changes in the permissions for the access token that was saved in this repo as a secret. Can you confirm that the access token didn't change?

@NeilGorman104
Copy link
Collaborator Author

@edgarrmondragon It looks like our LinkedIn access token just expired. I'll generate a new token and add it to the secrets for the repo.

The access token was active when this test ran so I'm not sure whether or not it was an issue with the token being wrong

@NeilGorman104
Copy link
Collaborator Author

Hey @edgarrmondragon I have updated this repo and my fork with a newly generated access token. However, we are still facing the 401 error on the PR but my fork is still running the pytest without errors.

I am continuing to look into this. Do you know of any reasons that the same test would be giving different results across repos with the same secrets?

@edgarrmondragon edgarrmondragon changed the title refactor: LinkedIn 202305 updates refactor: Update tap to use the LinkedIn 202305 API Jul 5, 2023
@edgarrmondragon
Copy link
Member

Hey @edgarrmondragon I have updated this repo and my fork with a newly generated access token. However, we are still facing the 401 error on the PR but my fork is still running the pytest without errors.

I am continuing to look into this. Do you know of any reasons that the same test would be giving different results across repos with the same secrets?

@NeilGorman104 I can see in the workflow logs that the secret is not being used, but that's probably because we're merging from a fork because I can confirm the new token works fine in other PRs 👍

@edgarrmondragon
Copy link
Member

@NeilGorman104 This LGTM. If you're not planning to push more changes, we can merge this.

@NeilGorman104
Copy link
Collaborator Author

@edgarrmondragon Sounds good, merging this now

@NeilGorman104 NeilGorman104 enabled auto-merge (squash) July 6, 2023 19:26
@edgarrmondragon edgarrmondragon merged commit f0f38eb into MeltanoLabs:main Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants