fix: dict lookup and add Tests to verify things work properly (#40)

* Fix dict lookup and add Tests to verify things work properly

* Don't need extra request

* Only need to sync the stream once to prove it works

pyproject.toml

@@ -18,6 +18,7 @@ fs-s3fs = { version = "^1.1.1", optional = true}
 
 [tool.poetry.dev-dependencies]
 pytest = "^7.3.1"
+responses = "0.23.1"
 
 [tool.poetry.extras]
 s3 = ["fs-s3fs"]

tap_messagebird/streams.py

@@ -128,9 +128,9 @@ def validate_response(self, response: requests.Response) -> None:
                 f"{response.reason} for url: {response.url}"
             )
             response_json: dict = response.json()
-            error: dict = response_json["error"]
-            if response.status_code == 410 and error[0]["code"] == 21:
-                errmsg = f"{msg} {error=}"
+            errors: dict = response_json["errors"]
+            if response.status_code == 410 and errors[0]["code"] == 21:
+                errmsg = f"{msg} {errors=}"
                 raise ConversationArchivedWarning(errmsg)
         super().validate_response(response)
 

tests/test_core.py

@@ -1,11 +1,17 @@
 """Tests standard tap features using the built-in SDK tests library."""
 
 import os
+import typing
 
+import responses
 from singer_sdk.testing import get_standard_tap_tests
 
 from tap_messagebird.tap import TapMessagebird
 
+if typing.TYPE_CHECKING:
+    from tap_messagebird.streams import ConversationMessagesStream
+
+
 SAMPLE_CONFIG = {
     "api_key": os.getenv("TAP_MESSAGEBIRD_API_KEY"),
 }
@@ -17,3 +23,31 @@ def test_standard_tap_tests():
     tests = get_standard_tap_tests(TapMessagebird, config=SAMPLE_CONFIG)
     for test in tests:
         test()
+
+
+@responses.activate
+def test_missing_conversation():
+    """Sometimes conversations are missing."""
+    responses.get(
+        "https://conversations.messagebird.com/v1/conversations/123456/messages",
+        json={
+            "errors": [
+                {
+                    "code": 21,
+                    "description": "The conversation is deleted",
+                },
+            ],
+        },
+        status=410,
+        content_type="application/json",
+    )
+    # Don't need ENV variables here
+    tap: TapMessagebird = TapMessagebird(
+        config=SAMPLE_CONFIG,
+        parse_env_config=False,
+    )
+    conversation_message_stream: ConversationMessagesStream = tap.streams[
+        "conversation_message"
+    ]
+    context = {"_sdc_conversations_id": "123456"}
+    conversation_message_stream.sync(context)